https://bugzilla.redhat.com/show_bug.cgi?id=1836567 Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mail@fabian-affol | |ter.ch) | --- Comment #3 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- Thanks a lot for you rinput. (In reply to Javier Peña from comment #2) > The spec looks good, I just have a couple suggestions for fixes: > > - The documentation build from your source rpm shows a lot of errors due to > the graphql package not being available. I had some success by moving it to > the %install section and setting PYTHONPATH, just like you did in the %check > section for pytest. Moved, yes, that create a better result. > - python-sphinx_rtd_theme works as a build requirement, but I think it might > be cleaner to use python3-sphinx_rtd_theme (just a personal thing, feel free > to ignore if you have other preferences). No, that should be python3-sphinx_rtd_theme > - There is version 3.1.1 now, could you update your spec so that > fedora-review does not complain? Updated to 3.1.1 * Sat Jun 06 2020 Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> - 3.1.1-1 - Generate docs in install (rhbz#1836567) - Update BR name - Update to latest upstream release 3.1.1 Updates files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-graphql-core.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-graphql-core-3.1.1-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
