[Bug 1842042] Review Request: repo2module - A tool to take a yum repository and turn it into a Fedora module stream

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1842042



--- Comment #3 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> ---
> repo2module.x86_64: W: spelling-error %description -l en_US yaml -> yam, yams, yawl
>
> This should be YAML

The problem is that the yaml is a part of filename - modules.yaml . I cannot
uppercase it.


> repo2module.x86_64: E: no-binary
>
> Hmm. no idea what this means :( I am going to ignore this.

Me neither, there definitely is a binary


> repo2module.x86_64: E: non-executable-script /usr/lib/python3.9/site-packages/repo2module/cli.py 644 /usr/bin/python3
> 
> remove the executable bit please.

Actually there is no executable bit. There is a shebang in the cli.py file but
it is not executable.
I already created a PR removing it -
https://github.com/sgallagher/repo2module/pull/2
Therefore the error will disappear on a new release. Is it good enough? (IMHO
it is) or should I request a new
upstream release before finishing the package review?


> repo2module.x86_64: W: no-manual-page-for-binary repo2module
> 
> This would be nice to have, but I will not block a review on this.

Agreed, we will add some in the future.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux