[Bug 1795526] Review Request: ghc-cborg - Concise Binary Object Representation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1795526



--- Comment #15 from Jens Petersen <petersen@xxxxxxxxxx> ---
Hi Elliot, thanks for updating the review:

(In reply to Elliott Sales de Andrade from comment #14)
> These two should be fixed:
> 
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners:
>      /usr/share/doc/ghc/html/libraries, /usr/share/doc/ghc/html,
>      /usr/share/doc/ghc

Good catch, thanks!
I have fixed this in ghc-rpm-macros-2.0.9-1.fc33 .

> ghc-cborg-devel.x86_64: W: spurious-executable-perm
> /usr/share/doc/ghc-cborg-devel/ChangeLog.md

Yes, thanks, fixing - I worked around this cabal-install bug recently in
cabal-rpm.

> and I'm not sure about this one:
> 
> [?]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc-
>      cborg-prof

ghc-cborg-prof has
Requires:       %{name}-devel%{?_isa} = %{version}-%{release}

which in turn has
Requires:       %{name}%{?_isa} = %{version}-%{release}

So I think that is okay.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux