https://bugzilla.redhat.com/show_bug.cgi?id=1827939 Nils Philippsen <nphilipp@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #9 from Nils Philippsen <nphilipp@xxxxxxxxxx> --- (In reply to Guido Aulisi from comment #8) > > # Delete zero length file (probably needed to keep empty dir in GIT) > > rm %{buildroot}%{_datadir}/%{name}/templates/.stub > > > # Delete wscript file (merged upstream https://github.com/Ardour/ardour/pull/516) > > rm "%{buildroot}%{_datadir}/%{name}/plugin_metadata/wscript" > > These have to be moved before %find_lang, rpm looks for them: > > RPM build errors: > File not found: > /builddir/build/BUILDROOT/ardour6-6.0.0-2.fc33.x86_64/usr/share/ardour6/ > templates/.stub > File not found: > /builddir/build/BUILDROOT/ardour6-6.0.0-2.fc33.x86_64/usr/share/ardour6/ > plugin_metadata/wscript > > Sorry, that was my mistake. Let's share responsibility for this, I could have attempted to build the package myself. ;) With your suggested change it builds fine. > Pull request for wscript has been merged > > Package seems good to me now, I will post the last review log asap and > approve it when you fix the above error. > > If you want to build for f32 too, we should upgrade fluidsynth2 on f32 and > rebuild the dependant packages. ardour5 has already been patched for f33, it > could be patched on f32 too. Oh, not quite today. The number of dependants is a bit daunting and it would need much closer coordination in a stable release than what was needed in Rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
