https://bugzilla.redhat.com/show_bug.cgi?id=1821037 --- Comment #2 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> --- Hello Nicolas Sorry for my slow response. Please check the issues. Issues ====== License: field --------------- I think the license for this package must be "ASL 2.0, BSD, Boost and MIT" if this package includes files under the licenses described in THIRD-PARTY-PROGRAMS file and a comment right above the License: field should exist. Please see the following guideline: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios %license --------- I think THIRD-PARTY-PROGRAMS file must be included in %license if that file includes license text. Please see the following guideline: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Reference ========= I manually reviewed this package since I couldn't review this package by using fedora-review because of build errors inside mock in my environment. Rpmlint results --------------- ``` $ rpmlint ~/rpmbuild/RPMS/x86_64/onednn-1.4-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/x86_64/onednn-devel-1.4-1.fc33.x86_64.rpm onednn-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ~/rpmbuild/SRPMS/onednn-1.4-1.fc33.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ``` sha256sum results ----------------- ``` $ wget https://github.com/oneapi-src/oneDNN//archive/v1.4/onednn-1.4.tar.gz && sha256sum onednn-1.4.tar.gz 54737bcb4dc1961d32ee75da3ecc529fa48198f8b2ca863a079e19a9c4adb70f onednn-1.4.tar.gz $ sha256sum ~/rpmbuild/SOURCES/onednn-1.4.tar.gz 54737bcb4dc1961d32ee75da3ecc529fa48198f8b2ca863a079e19a9c4adb70f /home/vagrant/rpmbuild/SOURCES/onednn-1.4.tar.gz ``` Koji ----- http://koji.fedoraproject.org/koji/taskinfo?taskID=44863550 Thanks in advance, Hirotaka Wakabayashi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
