https://bugzilla.redhat.com/show_bug.cgi?id=1826621 --- Comment #25 from ArunPrabhu Vijayan <arunprabhu.vijayan@xxxxxxxxx> --- (In reply to Neil Horman from comment #24) > you still need to fix the items I emailed you about yesterday: > > 1) Document how to generate the rmd-extra-pkgs.tar.gz file > 2) Remove the scripts subdirectory from /etc/rmd and replace the needed > functionality by augmenting the %post and %preun scripts > 3) Add -p to the install commands to preserve selinux context > 4) Fix the man file inclusion to not specify .gz (use a * glob instead) > > Currently, your target is rawhide (the master branch of the git tree). We > can target others if you like, but I don't see a need at the moment All comments are fixed. Please find the SPEC file. https://raw.githubusercontent.com/arunprabhu123/rmd/master/rmd.spec Note: Am not able to upload the srpm to github as it is around 400MB. However, I updated rmd.spec to incorporate the comments. Currently there is only one script file in /etc/rmd/ --> setup_rmd_user.sh. The need for the same is documented in userguide.md file(part of docs) I'm getting new lint warnings due to these changes, rmd.x86_64: W: dangerous-command-in-%post chown rmd.x86_64: W: dangerous-command-in-%preun userdel These commands are required for installation & un-installation. Kindly let me know if it is Ok. Thanks in advance. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
