Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bibexport - Extract entries from BibTeX and .aux files https://bugzilla.redhat.com/show_bug.cgi?id=251525 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-10-23 00:19 EST ------- Builds fine; rpmlint says: bibexport.noarch: W: invalid-license LaTeX According to http://fedoraproject.org/wiki/Licensing, the License: tag should be "LPPL". Otherwise everything looks good. Review: * source files match upstream: 878458e6d161d876f049d2e2839e417260b50b180bb0756829a54e06cb18ed72 bibexport.zip * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license (well, it uses the wrong abbreviation) * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly X rpmlint has a valid complaint * final provides and requires are sane: bibexport = 2.10-1.fc8 = /bin/sh /usr/bin/texhash tetex * %check is not present; no test suite upstream. I have no idea at all how to test this package. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets look OK (texhash is called because of files in /usr/share/texmf/bibtex/bst/bibexport) * code, not content. * The documentation PDF is ten times the size of everything else in the package combined, but teh package is still only 160K so there's no point in splitting anything. * %docs are not necessary for the proper functioning of the package. APPROVED, provided you fix up the License: tag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review