https://bugzilla.redhat.com/show_bug.cgi?id=1836540 --- Comment #8 from Jerry James <loganjerry@xxxxxxxxx> --- All you can do is all I can ask. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== ISSUES ===== - Remove these lines at the top of the spec file: #find-debuginfo.sh does not pick-up the debuginfo for whatever reason. #when built, the .debug file shows in usr/lib/debug/usr/bin %global debug_package %{nil} They are wrong. The debuginfo is generated correctly. - The %cmake macro already includes -DCMAKE_INSTALL_PREFIX:PATH=/usr in its expansion, so you don't need to specify it again. All you need is "%cmake .". - The %doc macro puts README into /usr/share/doc/mudita24. The package's install target puts README.profiles int /usr/share/doc/mudiat24-1.1.0. That seems wrong. We should create a single doc directory for both files. You've got at least these alternatives (I haven't tried any of them, so they may need some tweaking): o Pass -Dmudita24_DOC_DIR:PATH=%{_docdir}/%{name} to %cmake and change the last %files entry to %{_docdir}/%{name}/README.profiles o At the end of %install, do this: mv %{buildroot}%{_datadir}/doc/mudita24-%{version} %{buildroot}%{_datadir}/doc/mudita24 and make the same %files change as above o At the end of %install, do this: rm -rf %{buildroot}%{_datadir}/doc/mudita24-%{version} And then in %files do this: %doc README mudita24/README.profiles and just remove the last line in %files - The %changelog entry has a '-' in the version where it should have a '.'; it should be 1.1.0-1.20160218gite38b1a3 instead of 1.1.0-1-20160218gite38b1a3. - Since this package uses pkg-config to find its dependencies, use the "pkgconfig" form of dependency for the BuildRequires. In particular, "BuildRequires: pkgconfig(alsa)" instead of alsa-lib-devel, and "BuildRequires: pkgconfig(gtk+-2.0)" instead of gtk2-devel. See https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/ - Upstream hasn't been active for awhile, but could you ask them to fix the FSF's address? It's probably best if they just grab a new copy of COPYING from https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt as a few other minor things have changed in the last decade and a half or so. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. No %check script, but upstream provides no tests. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mudita24-1.1.0-1.20160218gite38b1a3.fc33.x86_64.rpm mudita24-1.1.0-1.20160218gite38b1a3.fc33.src.rpm mudita24.x86_64: W: spelling-error Summary(en_US) soundcards -> sound cards, sound-cards, soundboards mudita24.x86_64: W: spelling-error %description -l en_US alsa -> alas, salsa, balsa mudita24.x86_64: W: spelling-error %description -l en_US chipset -> chip set, chip-set, chippie mudita24.x86_64: W: spelling-error %description -l en_US abidings -> abiding, abiding s, bindings mudita24.x86_64: W: spelling-error %description -l en_US mudita -> audit mudita24.x86_64: W: spelling-error %description -l en_US alsamixer -> balsamic mudita24.x86_64: W: spelling-error %description -l en_US Terratec -> Terrace, Terrance, Serrate mudita24.x86_64: W: spelling-error %description -l en_US Hoontech -> Nontechnical mudita24.x86_64: W: spelling-error %description -l en_US Digigram -> Diagram, Radiogram mudita24.x86_64: W: spelling-error %description -l en_US Lionstracs -> Abstractions, Contractions, Transactions mudita24.x86_64: W: spelling-error %description -l en_US Terrasoniq -> Ultrasonic mudita24.x86_64: W: incoherent-version-in-changelog 1.1.0-1-20160218gite38b1a3 ['1.1.0-1.20160218gite38b1a3.fc33', '1.1.0-1.20160218gite38b1a3'] mudita24.x86_64: W: unstripped-binary-or-object /usr/bin/mudita24 mudita24.x86_64: E: incorrect-fsf-address /usr/share/licenses/mudita24/COPYING mudita24.x86_64: W: no-manual-page-for-binary mudita24 mudita24.src: W: spelling-error Summary(en_US) soundcards -> sound cards, sound-cards, soundboards mudita24.src: W: spelling-error %description -l en_US alsa -> alas, salsa, balsa mudita24.src: W: spelling-error %description -l en_US chipset -> chip set, chip-set, chippie mudita24.src: W: spelling-error %description -l en_US abidings -> abiding, abiding s, bindings mudita24.src: W: spelling-error %description -l en_US mudita -> audit mudita24.src: W: spelling-error %description -l en_US alsamixer -> balsamic mudita24.src: W: spelling-error %description -l en_US Terratec -> Terrace, Terrance, Serrate mudita24.src: W: spelling-error %description -l en_US Hoontech -> Nontechnical mudita24.src: W: spelling-error %description -l en_US Digigram -> Diagram, Radiogram mudita24.src: W: spelling-error %description -l en_US Lionstracs -> Abstractions, Contractions, Transactions mudita24.src: W: spelling-error %description -l en_US Terrasoniq -> Ultrasonic 2 packages and 0 specfiles checked; 1 errors, 25 warnings. Rpmlint (installed packages) ---------------------------- mudita24.x86_64: W: spelling-error Summary(en_US) soundcards -> sound cards, sound-cards, soundboards mudita24.x86_64: W: spelling-error %description -l en_US alsa -> alas, salsa, balsa mudita24.x86_64: W: spelling-error %description -l en_US chipset -> chip set, chip-set, chippie mudita24.x86_64: W: spelling-error %description -l en_US abidings -> abiding, abiding s, bindings mudita24.x86_64: W: spelling-error %description -l en_US mudita -> audit mudita24.x86_64: W: spelling-error %description -l en_US alsamixer -> balsamic mudita24.x86_64: W: spelling-error %description -l en_US Terratec -> Terrace, Terrance, Serrate mudita24.x86_64: W: spelling-error %description -l en_US Hoontech -> Nontechnical mudita24.x86_64: W: spelling-error %description -l en_US Digigram -> Diagram, Radiogram mudita24.x86_64: W: spelling-error %description -l en_US Lionstracs -> Abstractions, Contractions, Transactions mudita24.x86_64: W: spelling-error %description -l en_US Terrasoniq -> Ultrasonic mudita24.x86_64: W: incoherent-version-in-changelog 1.1.0-1-20160218gite38b1a3 ['1.1.0-1.20160218gite38b1a3.fc33', '1.1.0-1.20160218gite38b1a3'] mudita24.x86_64: W: unstripped-binary-or-object /usr/bin/mudita24 mudita24.x86_64: E: incorrect-fsf-address /usr/share/licenses/mudita24/COPYING mudita24.x86_64: W: no-manual-page-for-binary mudita24 1 packages and 0 specfiles checked; 1 errors, 14 warnings. Source checksums ---------------- https://github.com/NielsMayer/mudita24/archive/e38b1a39a8ca4f82b74d7b70bf9a3489e37b3588/mudita24-e38b1a3.tar.gz : CHECKSUM(SHA256) this package : fd0db2c1ea3c5ad75d394d965b0152c36fcb6e1a6170aaf0243e25f2358bdd64 CHECKSUM(SHA256) upstream package : fd0db2c1ea3c5ad75d394d965b0152c36fcb6e1a6170aaf0243e25f2358bdd64 Requires -------- mudita24 (rpmlib, GLIBC filtered): alsa-utils libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libc.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) rtld(GNU_HASH) Provides -------- mudita24: mudita24 mudita24(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1836540 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Perl, R, SugarActivity, PHP, fonts, Python, Ruby, Java, Haskell, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
