[Bug 1833475] Review Request: ocaml-ppx-compare - Generate comparison functions from types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1833475



--- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Ankur Sinha (FranciscoD) from comment #3)
> [x]: Requires correct, justified where necessary.
> ^
> Rather long list, but it looks OK. Please do double-check

Looks okay to me.

> [?]: Latest version is packaged.
> ^
> Uh, upstream just released a new version 2 days ago.
> https://github.com/janestreet/ppx_compare/releases

Yes, but we can't use it yet.  If you look at the ocaml-ppx* packages we
currently have in Fedora, you'll note that several of them are at version 0.13.
 They share an upstream (Jane Street), and are released together.  The 0.14
versions are out, but we'll have to update them all together.  I haven't had
time to do the mock builds yet to verify that nothing will break.  So, for now,
we need version 0.13 of this package; it will be updated to 0.14 when all the
others are.

> [?]: Patches link to upstream bugs/comments/lists or are otherwise
>      justified.
> ^
> Should the patch be sent upstream?

No, because another change to dune in the meantime made it unnecessary.  I have
dropped the patch.

New URLs:
Spec URL:
https://jjames.fedorapeople.org/ocaml-ppx-compare/ocaml-ppx-compare.spec
SRPM URL:
https://jjames.fedorapeople.org/ocaml-ppx-compare/ocaml-ppx-compare-0.13.0-2.fc33.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux