https://bugzilla.redhat.com/show_bug.cgi?id=1838686 Sandro Mani <manisandro@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #33 from Sandro Mani <manisandro@xxxxxxxxx> --- Only remaining remark: what's with these > # Remove duplicated cmake files (rpmlint complains) > #rm -f %%{buildroot}%%{_prefix}/lib/pdal/cmake/PDAL*.cmake I suppose you can just drop those lines from the spec? It's not like these file are appearing in any %files section. Everything else looks good, approved (take care of the above lines when importing the package as you see necessary). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
