Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ivtv-firmware - Firmware for hardware based on Conexant's CX23415/CX23416 codec chip https://bugzilla.redhat.com/show_bug.cgi?id=346171 ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-10-22 22:26 EST ------- You don't seem to have an srpm. I built one from the spec and everything looks good except for one issue: You cannot package the two .txt files as %doc; the license requires that they be included and installed in the same directory as the firmware itself. This means that they must be included even in a --nodocs installation. The only problem with keeping them in /lib/firmware is that they have somewhat generic names. I don't think anything prohibits you from renaming the license files; maybe you could prefix them with "ivtv-" so there would be slightly less confusion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review