https://bugzilla.redhat.com/show_bug.cgi?id=1835876 --- Comment #7 from Richard Shaw <hobbes1069@xxxxxxxxx> --- (In reply to Sandro Mani from comment #6) > > License: LGPLv2+ with exceptions > > Consider adding a comment (like the following from the native package) > # see COPYING (or http://www.fltk.org/COPYING.php ) for exceptions details > > > > Patch0: mingw-fltk-cmake.patch > > It's good practice to add a minimal comment as to the purpose of the patch. > > > > {?mingw_debug_package} > > Typo, should be %{?mingw_debug_package} > > > > %exclude %{mingw32_bindir}/lib*.dll.debug > > %exclude %{mingw32_datadir}/man/* > > The debug exclude shouldn't isn't necessary. The man pages you'll probably > want to explicitly remove them in %install. > > Rest is good. Please fix at least the debug typo when importing. Approved. > > (General mingw remark: I typically try to patch the buildsystem to output > versioned dlls, i.e. in this case something like > > diff -rupN fltk-1.3.5/CMake/macros.cmake fltk-1.3.5-new/CMake/macros.cmake > --- fltk-1.3.5/CMake/macros.cmake 2019-03-03 09:40:23.000000000 +0100 > +++ fltk-1.3.5-new/CMake/macros.cmake 2020-05-22 20:31:04.755781310 +0200 > @@ -51,6 +51,9 @@ macro(FL_ADD_LIBRARY LIBNAME LIBTYPE LIB > SOVERSION ${FLTK_VERSION_MAJOR}.${FLTK_VERSION_MINOR} > PREFIX "lib" # for MSVC static/shared coexistence > ) > + if(MINGW) > + set_target_properties(${LIBRARY_NAME} PROPERTIES SUFFIX > "-${FLTK_VERSION_MAJOR}${CMAKE_SHARED_LIBRARY_SUFFIX}") > + endif(MINGW) > endif (${LIBTYPE} STREQUAL "SHARED") > > if (MSVC) > > but up to you) Hmm... Is this useful on mingw? Typically the dlls get bundled up with an installer so we don't have the same issue as a system based install on linux. Also, wouldn't setting the SOVERSION property be the correct way? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
