[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1838686



--- Comment #29 from Sandro Mani <manisandro@xxxxxxxxx> ---
> I went through the licensecheck.txt file and verified the unclear extractions within the files.
> Would the following change be ok (twice in the spec file)? 

> -%license LICENSE.txt
> +%license Apache License 2.0 and Boost Software License 1.0 and BSD 2-clause "Simplified" License and BSD 3-clause "New" or "Revised" License and Expat License and NTP License and SIL Open Font License 1.1 > and zlib/libpng license

No, it's the License field in the head section where you need to list all the
license names, and then include the respective license files via %license in
the corresponding package.

Actually, looking closer at the boost stuff, it appears that pdalboost is just
a bundled boost, and of all that code only boost_filesystem is actually used in
pdal/util/FileUtils.cpp. It's easy to unbundle, see [1], but you might want to
ask upstream why they felt the need to bundle and renamespace the boost as
pdalboost just for that one module. In particular, they might just want to use
std::filesystem and do away with boost altogether.

So, this said, as far as the license is concerned you need to use the license
names listed here [2], so you'd write something like

# The code is licensed BSD except for:
# - filters/private/csf/* and plugins/i3s/lepcc/* are ASL 2.0
# - vendor/arbiter/*, plugins/nitf/io/nitflib.h and plugins/oci/io/OciWrapper.*
are Expat/MIT
# - plugins/e57/libE57Format/{src,include}/* is Boost
License: BSD and ASL 2.0 and MIT and Boost

License files to include in the libs package:
PDAL-2.1.0-src/LICENSE.txt
PDAL-2.1.0-src/vendor/arbiter/LICENSE
PDAL-2.1.0-src/plugins/e57/libE57Format/LICENSE.md

where I've omitted everything under pdalboost as it's now unbundled.

[1] https://smani.fedorapeople.org/review/PDAL/
[2]
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Software_License_List


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux