https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #27 from Sandro Mani <manisandro@xxxxxxxxx> --- Created attachment 1692463 --> https://bugzilla.redhat.com/attachment.cgi?id=1692463&action=edit licensecheck.txt Full review below. Issues: [!]: License field in the package spec file matches the actual license. => In bundled code and elsewhere, in addition to BSD you also have code licensed ASL2.0, Expat and various flavours of the boost licence. You'll need to add the licenses of code which is actually compiled into the libraries (so i.e. not tests) to the License field and add a comment on the license breakdown. See attached licensecheck.txt for details. PDAL.src:157: E: hardcoded-library-path in %{_prefix}/lib/pdal/cmake/PDAL*.cmake => Can't spot where rpmlint picked this one out, I'd quickly check if the installed cmake files actually work (since the path referenced there does not exist), and if yes, then I'd ignore this one Rest looks good. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License", "*No copyright* BSD 3-clause "New" or "Revised" License", "BSD 3-clause "New" or "Revised" License Apache License 2.0", "Expat License", "*No copyright* Apache License 2.0", "Boost Software License 1.0", "BSD 2-clause "Simplified" License", "Apache License 2.0", "*No copyright* Boost Software License 1.0", "Boost Software License 1.0 [generated file]", "NTP License", "SIL Open Font License 1.1", "zlib/libpng license Boost Software License 1.0", "Public domain Boost Software License 1.0", "NTP License Boost Software License 1.0". 1253 files have unknown license. Detailed output of licensecheck in /home/sandro/Desktop/1838686-PDAL/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 2.3 starting (python version = 3.8.3)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.3 INFO: Mock Version: 2.3 Finish: chroot init INFO: installing package(s): /home/sandro/Desktop/1838686-PDAL/results/PDAL-debuginfo-2.1.0-4.fc33.x86_64.rpm /home/sandro/Desktop/1838686-PDAL/results/PDAL-libs-debuginfo-2.1.0-4.fc33.x86_64.rpm /home/sandro/Desktop/1838686-PDAL/results/PDAL-debugsource-2.1.0-4.fc33.x86_64.rpm /home/sandro/Desktop/1838686-PDAL/results/PDAL-devel-2.1.0-4.fc33.x86_64.rpm /home/sandro/Desktop/1838686-PDAL/results/PDAL-2.1.0-4.fc33.x86_64.rpm /home/sandro/Desktop/1838686-PDAL/results/PDAL-doc-2.1.0-4.fc33.noarch.rpm /home/sandro/Desktop/1838686-PDAL/results/PDAL-libs-2.1.0-4.fc33.x86_64.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 29 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/sandro/Desktop/1838686-PDAL/results/PDAL-debuginfo-2.1.0-4.fc33.x86_64.rpm /home/sandro/Desktop/1838686-PDAL/results/PDAL-libs-debuginfo-2.1.0-4.fc33.x86_64.rpm /home/sandro/Desktop/1838686-PDAL/results/PDAL-debugsource-2.1.0-4.fc33.x86_64.rpm /home/sandro/Desktop/1838686-PDAL/results/PDAL-devel-2.1.0-4.fc33.x86_64.rpm /home/sandro/Desktop/1838686-PDAL/results/PDAL-2.1.0-4.fc33.x86_64.rpm /home/sandro/Desktop/1838686-PDAL/results/PDAL-doc-2.1.0-4.fc33.noarch.rpm /home/sandro/Desktop/1838686-PDAL/results/PDAL-libs-2.1.0-4.fc33.x86_64.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: PDAL-2.1.0-4.fc33.x86_64.rpm PDAL-devel-2.1.0-4.fc33.x86_64.rpm PDAL-libs-2.1.0-4.fc33.x86_64.rpm PDAL-doc-2.1.0-4.fc33.noarch.rpm PDAL-debuginfo-2.1.0-4.fc33.x86_64.rpm PDAL-debugsource-2.1.0-4.fc33.x86_64.rpm PDAL-2.1.0-4.fc33.src.rpm PDAL.x86_64: W: no-documentation PDAL.x86_64: W: no-manual-page-for-binary pdal PDAL-devel.x86_64: W: no-documentation PDAL-devel.x86_64: W: no-manual-page-for-binary pdal-config PDAL-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libpdal_base.so.11 exit@GLIBC_2.2.5 PDAL-libs.x86_64: W: no-documentation PDAL-doc.noarch: W: hidden-file-or-dir /usr/share/doc/PDAL-doc/html/.buildinfo PDAL-doc.noarch: W: hidden-file-or-dir /usr/share/doc/PDAL-doc/html/.doctrees PDAL-doc.noarch: W: hidden-file-or-dir /usr/share/doc/PDAL-doc/html/.doctrees PDAL-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/PDAL-doc/html/_static/logo/sticker/front.ai PDAL-doc.noarch: W: file-not-utf8 /usr/share/doc/PDAL-doc/html/_static/logo/sticker/front.ai PDAL-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/PDAL-doc/html/_static/logo/sticker/iheartpdal.ai PDAL-doc.noarch: W: file-not-utf8 /usr/share/doc/PDAL-doc/html/_static/logo/sticker/iheartpdal.ai PDAL-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/PDAL-doc/html/_static/logo/sticker/sticker.ai PDAL-doc.noarch: W: file-not-utf8 /usr/share/doc/PDAL-doc/html/_static/logo/sticker/sticker.ai PDAL.src:63: W: unversioned-explicit-provides bundled(arbiter) PDAL.src:65: W: unversioned-explicit-provides bundled(PoissonRecon) PDAL.src:67: W: unversioned-explicit-provides bundled(nanoflann) PDAL.src:69: W: unversioned-explicit-provides bundled(nlohmann) PDAL.src:157: E: hardcoded-library-path in %{_prefix}/lib/pdal/cmake/PDAL*.cmake PDAL.src:160: W: macro-in-comment %{buildroot} PDAL.src:160: W: macro-in-comment %{_prefix} PDAL.src:161: W: macro-in-comment %{buildroot} PDAL.src:161: W: macro-in-comment %{_prefix} PDAL.src:162: W: macro-in-comment %{buildroot} PDAL.src:162: W: macro-in-comment %{_prefix} PDAL.src:110: W: mixed-use-of-spaces-and-tabs (spaces: line 110, tab: line 1) 7 packages and 0 specfiles checked; 1 errors, 26 warnings. Source checksums ---------------- https://github.com/PDAL/PDAL/releases/download/2.1.0/PDAL-2.1.0-src.tar.gz : CHECKSUM(SHA256) this package : c300de7935d52cb96e24bdaceea5d189b1840e88636e6deca1f6dad51f909571 CHECKSUM(SHA256) upstream package : c300de7935d52cb96e24bdaceea5d189b1840e88636e6deca1f6dad51f909571 Requires -------- PDAL (rpmlib, GLIBC filtered): PDAL-libs(x86-64) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libpdal_base.so.10()(64bit) libpdal_util.so.10()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) PDAL-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config /usr/bin/sh PDAL-libs(x86-64) cmake-filesystem(x86-64) libpdal_base.so.10()(64bit) libpdal_plugin_kernel_fauxplugin.so.10()(64bit) libpdal_plugin_reader_pgpointcloud.so.10()(64bit) libpdal_plugin_writer_pgpointcloud.so.10()(64bit) libpdal_util.so.10()(64bit) pkgconfig(gdal) pkgconfig(libxml-2.0) PDAL-libs (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdal.so.27()(64bit) libgeotiff.so.5()(64bit) liblaszip.so.8()(64bit) libm.so.6()(64bit) libpdal_base.so.10()(64bit) libpdal_util.so.10()(64bit) libpq.so.5()(64bit) libpq.so.5(RHPG_9.6)(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.8)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.6.2)(64bit) libxml2.so.2(LIBXML2_2.6.23)(64bit) libxml2.so.2(LIBXML2_2.6.5)(64bit) libz.so.1()(64bit) libzstd.so.1()(64bit) rtld(GNU_HASH) PDAL-doc (rpmlib, GLIBC filtered): PDAL-debuginfo (rpmlib, GLIBC filtered): PDAL-debugsource (rpmlib, GLIBC filtered): Provides -------- PDAL: PDAL PDAL(x86-64) bundled(PoissonRecon) bundled(arbiter) bundled(nanoflann) bundled(nlohmann) PDAL-devel: PDAL-devel PDAL-devel(x86-64) cmake(PDAL) cmake(pdal) pkgconfig(pdal) PDAL-libs: PDAL-libs PDAL-libs(x86-64) libpdal_base.so.10()(64bit) libpdal_util.so.10()(64bit) PDAL-doc: PDAL-doc PDAL-debuginfo: PDAL-debuginfo PDAL-debuginfo(x86-64) debuginfo(build-id) PDAL-debugsource: PDAL-debugsource PDAL-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1838686 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Haskell, R, Python, PHP, SugarActivity, Java, Perl, Ocaml, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
