https://bugzilla.redhat.com/show_bug.cgi?id=1833474 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Ankur Sinha (FranciscoD) from comment #1) > Looks pretty good. A couple of things that I need to double-check before > approving: > > - the ppx.exe file extension isn't listed in the guidelines, is that OK? Yes. It's a helper application. Several of the ocaml-ppx* packages have them (or will have them, once they are introduced into Fedora). > - are the build flags used in `dune build`? They are. Dune itself invokes the underlying ocaml tools to do the actual building. Richard Jones has made those tools use the Fedora build flags. Using readelf, for example, you can see that the binaries were all built with relro. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
