[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1838686



--- Comment #20 from markusN <neteler@xxxxxxxxx> ---
Concerning the library versioning (answer by the PDAL maintainer):

> The library versioning adopted by PDAL is pretty unusual, i.e. in CMakeLists.txt
This was a bug that is fixed in https://github.com/PDAL/PDAL/pull/3042. This is
merged to the 2.1-maintenance branch and will be included in PDAL 2.1.1, which
is expected by the end of June 2020.


Concerning the failing pgpointcloudtest:

- https://github.com/PDAL/PDAL/issues/742 "Test for pgpointcloud fails"

First I tried to define the PG related env vars:

%check
# test the compiled code (see doc/project/testing.rst)
PGUSER=pdal PGPASSWORD=password PGHOST=localhost PGPORT=5432 ctest -V

Also now this test is still failing ("could not connect to server: Connection
refused").
I suspect that during the RPM compilation the PG server is simply not running
and I have no idea how to start that in the SPEC file.
Debian seems to face the same test problem, they have work-arounded it like
this:

ctest -V --exclude-regex "pgpointcloudtest"

Now, 
- we can deactivate the PostgreSQL support entirely as I was not able to find
so far a SPEC file with working ctest-running PostgreSQL combo.
- or skip the pgpointcloudtest test.

Hence, I now adopted the next suggestion from above PDAL ticket 742 to skip the
test:
-D BUILD_PGPOINTCLOUD_TESTS:BOOL=OFF



Latest log:
https://koji.fedoraproject.org/koji/taskinfo?taskID=44957096

successes:
- i686
- x86_64


remaining failures:
- armv7hl 
(https://kojipkgs.fedoraproject.org//work/tasks/7211/44957211/build.log):
 Start  38: pdal_io_las_writer_test
38: Test command:
/builddir/build/BUILD/PDAL-2.1.0-src/bin/pdal_io_las_writer_test
38: Environment variables: 
38:  PDAL_DRIVER_PATH=/builddir/build/BUILD/PDAL-2.1.0-src/lib
38: Test timeout computed to be: 10000000
38: [==========] Running 27 tests from 1 test suite.
38: [----------] Global test environment set-up.
38: [----------] 27 tests from LasWriterTest
38: [ RUN      ] LasWriterTest.srs
38: [       OK ] LasWriterTest.srs (35 ms)
38: [ RUN      ] LasWriterTest.srs2
38: [       OK ] LasWriterTest.srs2 (12 ms)
38: [ RUN      ] LasWriterTest.auto_offset
38: [       OK ] LasWriterTest.auto_offset (10 ms)
38: [ RUN      ] LasWriterTest.auto_offset2
38: [       OK ] LasWriterTest.auto_offset2 (15 ms)
38: [ RUN      ] LasWriterTest.extra_dims
38: [       OK ] LasWriterTest.extra_dims (16 ms)
38: [ RUN      ] LasWriterTest.all_extra_dims
38: [       OK ] LasWriterTest.all_extra_dims (24 ms)
38: [ RUN      ] LasWriterTest.forward
38: (readers.las Error) GDAL failure (1) PROJ: proj_create_from_database: crs
not found
38: (readers.las Error) GDAL failure (1) PROJ: proj_create_from_database: crs
not found
38: [       OK ] LasWriterTest.forward (1204 ms)
38: [ RUN      ] LasWriterTest.forwardvlr
38: proj_uom_get_info_from_database: unit of measure not found
38: [       OK ] LasWriterTest.forwardvlr (85 ms)
38: [ RUN      ] LasWriterTest.flex
38: [       OK ] LasWriterTest.flex (16 ms)
38: [ RUN      ] LasWriterTest.flex2
38: [       OK ] LasWriterTest.flex2 (11 ms)
38: [ RUN      ] LasWriterTest.laszip
38: [       OK ] LasWriterTest.laszip (797 ms)
38: [ RUN      ] LasWriterTest.laszip1_4
 38/107 Test  #38: pdal_io_las_writer_test ................Bus
error***Exception:   3.11 sec


aarch64
(https://kojipkgs.fedoraproject.org//work/tasks/7214/44957214/build.log):
        Start  89: pdal_filters_stats_test
89: Test command:
/builddir/build/BUILD/PDAL-2.1.0-src/bin/pdal_filters_stats_test
89: Environment variables: 
89:  PDAL_DRIVER_PATH=/builddir/build/BUILD/PDAL-2.1.0-src/lib64
89: Test timeout computed to be: 10000000
89: [==========] Running 9 tests from 1 test suite.
89: [----------] Global test environment set-up.
89: [----------] 9 tests from Stats
89: [ RUN      ] Stats.handcalc
89: [       OK ] Stats.handcalc (2 ms)
89: [ RUN      ] Stats.baseline
89: [       OK ] Stats.baseline (2 ms)
89: [ RUN      ] Stats.simple
89: [       OK ] Stats.simple (2 ms)
89: [ RUN      ] Stats.advanced
89:
/builddir/build/BUILD/PDAL-2.1.0-src/test/unit/filters/StatsFilterTest.cpp:211:
Failure
89: The difference between statsX.sampleSkewness() and -5.2235397e-16 is
1.9919314947420312e-18, which exceeds 1e-23, where
89: statsX.sampleSkewness() evaluates to -5.2036203850525794e-16,
89: -5.2235397e-16 evaluates to -5.2235396999999997e-16, and
89: 1e-23 evaluates to 9.9999999999999996e-24.
89:
/builddir/build/BUILD/PDAL-2.1.0-src/test/unit/filters/StatsFilterTest.cpp:212:
Failure
89: The difference between statsY.sampleSkewness() and -5.7098153e-16 is
1.1898719537472993e-20, which exceeds 1e-23, where
89: statsY.sampleSkewness() evaluates to -5.7096963128046251e-16,
89: -5.7098153e-16 evaluates to -5.7098152999999998e-16, and
89: 1e-23 evaluates to 9.9999999999999996e-24.
89:
/builddir/build/BUILD/PDAL-2.1.0-src/test/unit/filters/StatsFilterTest.cpp:213:
Failure
89: The difference between statsZ.sampleSkewness() and -5.5176534e-16 is
6.8715912016394351e-19, which exceeds 1e-23, where
89: statsZ.sampleSkewness() evaluates to -5.5245249912016398e-16,
89: -5.5176534e-16 evaluates to -5.5176534000000004e-16, and
89: 1e-23 evaluates to 9.9999999999999996e-24.
89: [  FAILED  ] Stats.advanced (2 ms)
89: [ RUN      ] Stats.stream
89: [       OK ] Stats.stream (1 ms)
89: [ RUN      ] Stats.dimset
89: [       OK ] Stats.dimset (2 ms)
89: [ RUN      ] Stats.metadata
89: [       OK ] Stats.metadata (1 ms)
89: [ RUN      ] Stats.enum
89: [       OK ] Stats.enum (1 ms)
89: [ RUN      ] Stats.global
89: [       OK ] Stats.global (1 ms)
89: [----------] 9 tests from Stats (14 ms total)
89: 
89: [----------] Global test environment tear-down
89: [==========] 9 tests from 1 test suite ran. (14 ms total)
89: [  PASSED  ] 8 tests.
89: [  FAILED  ] 1 test, listed below:
89: [  FAILED  ] Stats.advanced
89: 
89:  1 FAILED TEST
 89/107 Test  #89: pdal_filters_stats_test ................***Failed    0.19
sec


- s390x
(https://kojipkgs.fedoraproject.org//work/tasks/7216/44957216/build.log):
The following tests FAILED:
          9 - pdal_metadata_test (Failed)
         19 - pdal_polygon_test (Failed)
         21 - pdal_spatial_reference_test (Failed)
         32 - pdal_io_ept_reader_test (Failed)
         37 - pdal_io_las_reader_test (Failed)
         38 - pdal_io_las_writer_test (Failed)
         45 - pdal_io_qfit_test (Failed)
         48 - pdal_io_terrasolid_test (Failed)
         56 - pdal_filters_crop_test (Failed)
         77 - pdal_filters_overlay_test (Failed)
         79 - pdal_filters_reprojection_test (Failed)
         89 - pdal_filters_stats_test (Failed)
         91 - pdal_filters_hexbin_test (Failed)
         96 - pdal_info_test (Failed)
         97 - pdal_tile_test (Failed)


In addition I tried EPEL8:
https://koji.fedoraproject.org/koji/taskinfo?taskID=44959014

DEBUG util.py:600:  No matching package to install: 'gdal'
DEBUG util.py:600:  No matching package to install: 'gdal-devel'
DEBUG util.py:600:  No matching package to install: 'laszip-devel'
DEBUG util.py:600:  No matching package to install: 'python3-breathe'
DEBUG util.py:600:  No matching package to install:
'python3-sphinxcontrib-bibtex'
DEBUG util.py:600:  Not all dependencies satisfied

This might be addressed at a later point (locally I have already compiled PDAL
on EPEL8 without sphinx docs).


My question is: do all architecture have to be supported to get PDAL accepted
in Fedora?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux