https://bugzilla.redhat.com/show_bug.cgi?id=1832562 Purusharth S <purusharth.saxena1@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(sanjay.ankur@gmai | |l.com) --- Comment #4 from Purusharth S <purusharth.saxena1@xxxxxxxxx> --- Hey Ankur, Thanks for letting me know. I wasn't sure if the `fedora-review` would pick up the urls from the comments so I updated the previous one itself. Will keep that in mind :) And, thanks for the review as well. Here are the updated files: Spec URL: https://pagure.io/tpcclib/raw/version-0.7.5/f/tpcclib.spec SRPM URL: https://pagure.io/tpcclib/raw/version-0.7.5/f/tpcclib-0.7.5-1.fc32.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=44424439 I've kept the licence as GPLv3 itself as per the discussion over devel. I also confirmed it with upstream over email (below) > The files with GPL 2 license were actually not included in compilation and are now removed. > Most of the small files without license are test data which obviously cannot be edited to contain > license, but I have omitted the license from individual code files too, > because I hope it would be sufficient to have GPL3 in the main docs, covering the whole library. Let me know if this is okay? Also, I have some questions wrt reviewing process. Will ask that over sig irc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
