https://bugzilla.redhat.com/show_bug.cgi?id=1827939 --- Comment #2 from Guido Aulisi <guido.aulisi@xxxxxxxxx> --- This section is not correct imho, it seems that if checks are not enabled, then appdata is not validated: > %if %{with tests} > %check > WAFTPATH="$PWD/doc/waft" > pushd libs/ardour > sh "$WAFTPATH" --targets=libardour-tests && LV2_PATH= ./run-tests.sh > popd > # check appdata file > appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/appdata/%{name}.appdata.xml > %endif > rm -f %{buildroot}%{_bindir}/run-tests I would change it to: %check %if %{with tests} WAFTPATH="$PWD/doc/waft" pushd libs/ardour sh "$WAFTPATH" --targets=libardour-tests && LV2_PATH= ./run-tests.sh popd rm -f %{buildroot}%{_bindir}/run-tests %endif # check appdata file appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/appdata/%{name}.appdata.xml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
