https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #5 from markusN <neteler@xxxxxxxxx> --- (In reply to Sandro Mani from comment #4) > Created attachment 1691203 [details] > PDAL.spec > > Attached a spec with some fixes: > > - Correctly unbundle eigen3 and gtest > - Correctly build and run tests Thanks for this. > - Actually build docs instead of packaging the sources Right, of course the way to go. BTW, the wrong file permissions have been addressed today: https://github.com/PDAL/PDAL/pull/3093 > - Fix provides_excludes_from > - Move unversioned so libraries to -devel Thanks also here. > Open issues: > > - The library versioning adopted by PDAL is pretty unusual, i.e. in > CMakeLists.txt > > set(PDAL_API_VERSION "10") > set(PDAL_BUILD_VERSION "11") > > [...] This had been fixed upstream and will be part of the next PDAL release: https://github.com/PDAL/PDAL/pull/3042 > - PDAL-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libpdal_base.so.11 > exit@GLIBC_2.2.5 > > You should report this upstream, a shared library should never call exit, as > this will result in an application using the library to quit if the > respective condition is met (rather, the library should notify the > application about this condition, say via exceptions or some error handler > mechanism, so that the application can then choose how to proceed). I have now reported that at https://github.com/PDAL/PDAL/issues/3094 I see that you have developed two patches - Patch0: PDAL_unbundle.patch - Patch1: PDAL_tests.patch Would you mind to add them here as well? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
