[Bug 1836542] Review Request: studio-controls - Studio control for audio devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1836542



--- Comment #3 from Lyes Saadi <fedora@xxxxxxx> ---
Thank you for your quick answer!

> Added all of those except jack-audio-connection-kit-example-clients as it was already there. :)

Ah, yes, my bad! I don't remember why I added it :P.

> Other than that, I think I got everything, but I'm human and therefore fallible, and probably missed at least something.

Oh, it's totally fine, this software is pretty hard to package and you did a
great job :).

You just forgot to add systemd user scriptlets aswell (I should have been
clearer, sorry):
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units

> %post
> %systemd_user_post %{name}.service
>
> %preun
> %systemd_user_preun %{name}.service

Except that, everything is fine and I should be able to approve the package ;)!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux