Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices https://bugzilla.redhat.com/show_bug.cgi?id=343871 dan@xxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From dan@xxxxxxxx 2007-10-22 11:27 EST ------- I have done yet a few changes: - separated the earth icon from icons.cpp and used it as an icon for the desktop file - disabled the parallel make build as it doesn't work, it looks like that the build system doesn't define _smp_mflags, so it is buildable in Koji, but on my machine it crashes. Probably there are missing some inter-file dependencies, but it is a qmake problem. The review is here: OK source files match upstream: a995b5ae55263975ba5de36f164094c2b18f8951 QLandkarte.2007.09.18.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (GPLv2+). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (development/i386) + in koji. OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK is a GUI app, desktop file is included This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review