https://bugzilla.redhat.com/show_bug.cgi?id=1839148 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Richard Shaw <hobbes1069@xxxxxxxxx> --- Ok, I'll preface this by saying I'm not an expert MinGW reviewer. I went ahead and ran fedora-review on the package even though a lot of it doesn't apply to MinGW packages. Requires -------- mingw32-protobuf-static (rpmlib, GLIBC filtered): mingw32-protobuf mingw64-protobuf-static (rpmlib, GLIBC filtered): mingw64-protobuf Should these require the main library? Being static they don't have any real dependency on them... The example spec file shows this but I don't see any hard requirement. https://fedoraproject.org/wiki/Packaging:MinGW#Compilation_of_binaries Not a show stopper. ***APPROVED*** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
