https://bugzilla.redhat.com/show_bug.cgi?id=1838686 Sandro Mani <manisandro@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |manisandro@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |manisandro@xxxxxxxxx Flags| |fedora-review? --- Comment #2 from Sandro Mani <manisandro@xxxxxxxxx> --- - BuildRequires: boost BuildRequires: boost-devel => boost-devel already pulls in boost - BuildRequires: bash-completion => Looks suspicious, why is this needed? - BuildRequires: proj => Shouldn't that be proj-devel? - BuildRequires: glibc-headers => Probably unnecessary - Requires: eigen3 => eigen3 is a pure development package, shipping only headers. Why is it required? - Requires: gdal Requires: geos Requires: laszip Requires: libgeotiff Requires: libzstd Requires: libxml2 Requires: postgresql Requires: python3 %if 0%{?rhel} >= 7 Requires: libqhull %else Requires: qhull %endif Requires: zlib Requires: libzstd => These are incorrect, they should be for PDAL-libs, but the requires are automatically generated, so you can just remove all these requires (i.e. see rpm -qp --requires PDAL-libs-2.1.0-3.fc33.x86_64.rpm) - Group: Development/Libraries => Not needed anymore - %setup -q -n %{name}-%{version}-src => I'd recommend to switch to %autosetup -p1 -n %{name}-%{version}-src - -D CMAKE_BUILD_TYPE=Release \ => You'll probably want -D CMAKE_BUILD_TYPE=RelWithDebInfo, although %cmake explicitly sets all CC/CXX/LDFLAGS, so you can also just drop CMAKE_BUILD_TYPE - make %{?_smp_mflags} => %make_build - make install/fast DESTDIR=%{buildroot} => %make_install - %{__rm} -f %{buildroot}%{_usr}/lib/pdal/cmake/PDAL*.cmake => rm -f %{buildroot}%{_prefix}/lib/pdal/cmake/PDAL*.cmake (the __ prefixed macros are internal ones and should not be used) - %postun -p /sbin/ldconfig %post -p /sbin/ldconfig => Not needed anymore post F28 (https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets) - Files: => %{_bindir}/pdal-config belongs to pdal-devel => %{_libdir}/libpdal_base.so and %{_libdir}/libpdal_util.so belong to pdal-devel => Don't use wildcards for the libraries, otherwise it's easy to miss soname bumps => %{_libdir}/libpdal_plugin* look like pdal plugins, which are not meant to be linked against by third party applications? If so, filter them from the provides (https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAndRequiresFiltering/) => %{_libdir}/cmake/PDAL/PDAL*.cmake: %{_libdir}/cmake/PDAL/ is unowned, I'd just write %{_libdir}/cmake/PDAL/ (it marks the directory and all items below as owned by the package) => Documentation is large (63MB), you must add a dedicated PDAL-doc noarch subpackage => License must always be installed, move %license LICENSE.txt to PDAL-libs which all other subpackages require. For the new PDAL-doc subpackage, you can add the license a second time for that package to avoid the PDAL-doc -> PDAL-libs dependency. - 3rd party libraries under PDAL-2.1.0-src/vendor/ => Explicitly remove them in %prep to make sure they are not used if you can use the system copy, otherwise add a bundled(...) provides => If you use the bundled libraries, you'll need to add the corresponding licenses to License and %license as well (there is various non-BSD code) - Tests: there appears to be a test suite, consider adding %check and running the test suite, or add a comment why this is not feasible - Relevant rpmlint output: PDAL.x86_64: E: explicit-lib-dependency libgeotiff PDAL.x86_64: E: explicit-lib-dependency libxml2 PDAL.x86_64: E: explicit-lib-dependency libzstd PDAL.x86_64: E: explicit-lib-dependency zlib PDAL.x86_64: W: devel-file-in-non-devel-package /usr/bin/pdal-config PDAL.x86_64: E: version-control-internal-file /usr/share/doc/PDAL/doc/.gitignore PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/_static/logo/Bauhaus93.ttf PDAL.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/PDAL/doc/_static/logo/sticker/front.ai PDAL.x86_64: W: file-not-utf8 /usr/share/doc/PDAL/doc/_static/logo/sticker/front.ai PDAL.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/PDAL/doc/_static/logo/sticker/iheartpdal.ai PDAL.x86_64: W: file-not-utf8 /usr/share/doc/PDAL/doc/_static/logo/sticker/iheartpdal.ai PDAL.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/PDAL/doc/_static/logo/sticker/sticker.ai PDAL.x86_64: W: file-not-utf8 /usr/share/doc/PDAL/doc/_static/logo/sticker/sticker.ai PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/miriamlibre-bold-webfont.eot PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/miriamlibre-bold-webfont.svg PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/miriamlibre-bold-webfont.ttf PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/miriamlibre-bold-webfont.woff PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/miriamlibre-bold-webfont.woff2 PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/miriamlibre-regular-webfont.eot PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/miriamlibre-regular-webfont.svg PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/miriamlibre-regular-webfont.ttf PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/miriamlibre-regular-webfont.woff PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/miriamlibre-regular-webfont.woff2 PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/sintony-bold-webfont.eot PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/sintony-bold-webfont.svg PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/sintony-bold-webfont.ttf PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/sintony-bold-webfont.woff PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/sintony-bold-webfont.woff2 PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/sintony-regular-webfont.eot PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/sintony-regular-webfont.svg PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/sintony-regular-webfont.ttf PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/sintony-regular-webfont.woff PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/pdal_rtd/static/fonts/sintony-regular-webfont.woff2 PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/stages/filters.statisticaloutlier.img1.png PDAL.x86_64: W: spurious-executable-perm /usr/share/doc/PDAL/doc/stages/filters.statisticaloutlier.img2.png PDAL.x86_64: E: version-control-internal-file /usr/share/doc/PDAL/doc/workshop/.gitignore PDAL-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libpdal_base.so.11 exit@GLIBC_2.2.5 PDAL-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libpdal_base.so PDAL-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libpdal_util.so 6 packages and 0 specfiles checked; 6 errors, 40 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
