[Bug 1838027] Review Request: zuul - Trunk Gating System

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1838027



--- Comment #4 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
8) 

%files doc
%doc build/html LICENSE README.fedora

LICENSE should be marked as %license, not %doc.

Other (sub)packages don't have LICENSE packaged at all.




9) rpmlint screams with problems. I've picked some I don't understand, are they
expected?

zuul.noarch: W: non-standard-gid /etc/zuul/zuul.conf zuul
zuul.noarch: E: non-readable /etc/zuul/zuul.conf 640
zuul.noarch: W: non-standard-uid /usr/lib64/zuul zuul
zuul.noarch: W: non-standard-gid /usr/lib64/zuul zuul
zuul.noarch: W: non-standard-uid /var/lib/zuul zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul zuul
zuul.noarch: W: non-standard-uid /var/lib/zuul/.ssh zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul/.ssh zuul
zuul.noarch: W: non-standard-uid /var/lib/zuul/ansible zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul/ansible zuul
zuul.noarch: W: non-standard-uid /var/lib/zuul/keys zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul/keys zuul
zuul.noarch: W: non-standard-uid /var/log/zuul zuul
zuul.noarch: W: non-standard-gid /var/log/zuul zuul
zuul-executor.noarch: W: non-standard-uid /var/lib/zuul/ansible zuul
zuul-executor.noarch: W: non-standard-gid /var/lib/zuul/ansible zuul
zuul-executor.noarch: W: non-standard-uid /var/lib/zuul/executor zuul
zuul-executor.noarch: W: non-standard-gid /var/lib/zuul/executor zuul


And some that should probably be fixed:

zuul.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/zuul/ansible/base/library/command.py 644
/usr/bin/python3 
zuul.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/zuul/ansible/base/library/zuul_console.py 644
/usr/bin/python3 
zuul.noarch: W: log-files-without-logrotate ['/var/log/zuul']
zuul-scheduler.noarch: W: empty-%postun
zuul-merger.noarch: W: empty-%postun
zuul-web.noarch: W: empty-%postun
zuul-executor.noarch: W: empty-%postun
zuul-fingergw.noarch: W: empty-%postun
zuul-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/zuul-doc/LICENSE


Those can (and should) be deleted:

zuul-doc.noarch: W: hidden-file-or-dir /usr/share/doc/zuul-doc/html/.buildinfo
zuul-doc.noarch: W: hidden-file-or-dir /usr/share/doc/zuul-doc/html/.doctrees


zuul.src:307: W: libdir-macro-in-noarch-package (main package) %dir %attr(0755,
zuul, zuul) %{_libdir}/zuul

This is a warning, but will actually break things if built on 64bit builder but
installed on 32bit system, %{_libdir} is /usr/lib64 on 64bits. Either the
package needs to be arched, or this needs to be hardcoded to %{_prefix}/lib.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux