https://bugzilla.redhat.com/show_bug.cgi?id=1838027 --- Comment #2 from Fabien Boucher <fboucher@xxxxxxxxxx> --- (In reply to Miro Hrončok from comment #1) > spec sanity: > > > 1) %global srcname zuul -> consider dropping this, I don't see it used > anywhere in the spec done > > 2) 0001-Remove-another-shebang-and-remove-useless-exec-bits.patch -> is the > mode thing supported by regular patch, or is %autosetup -S git needed for > this? Looking the buildroot yes the file mode is correct so I assume autosetup w/o -S git is sufficient > > 3) %package webui etc. -> should they all (except maybe doc) have: Requires: > %{name} = %{?epoch:%{epoch}:}%{version}-%{release} ? Done > > 4) Requires: git -> is git-core not good enough? Yes it seems sufficient, so I've switch for git-core. > > 5) various manual Requires on python3-... -> is the dependency generator > not working? I see you rm requirements.txt, why is that? > Ok so I'll have a deeper look into that in the next round. > > 6) # Fix non compliant shebangs ... -> the complex fins+sed can be replaced > with a single pathfix.py call (see /usr/bin/pathifx.py, also macronized as > %py3_shebang_fix in rawhide, backports in progress) > Done, but I was unable to use the macro neither to find it. > > 7) %{python3_sitelib}/zuul-*.egg-info -> consider adding trailing slash to > assert this is a directory Done -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
