[Bug 1837793] Review Request: golang-github-xiaq-persistent - Persistent data structures for Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1837793

Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> ---
- Could you please double check the hashing mismatch for the source before the
import?
- "%global golicenses epl-v10.html" could replace the "%license epl-v10.html"
entry in the %files section. I guess that the go2rpm script was not able to
pick the file up. Not a blocker but would be more aligned with Go spec files.


Otherwise looks good, package APPROVED.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Upstream MD5sum check error, diff is in
  /home/fab/Documents/repos/reviews/1837793-golang-github-xiaq-
  persistent/diff.txt
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. Licenses found: "Unknown or generated". 1 files have
     unknown license. Detailed output of licensecheck in
     /home/fab/Documents/repos/reviews/1837793-golang-github-xiaq-
     persistent/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/gocode/src/github.com(golang-github-dchest-uniuri-devel,
     golang-github-gopherjs-devel, golang-github-glycerine-unsnap-stream-
     [...]
     golang-github-nkovacs-streamquote-devel, golang-github-10gen-escaper-
     devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Bad spec filename:
     /home/fab/Documents/repos/reviews/1837793-golang-github-xiaq-
     persistent/srpm-unpacked/golang-github-xiaq-persistent.spec
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking:
golang-github-xiaq-persistent-devel-0-0.1.20200520gita1d9ac4.fc33.noarch.rpm
          golang-github-xiaq-persistent-0-0.1.20200520gita1d9ac4.fc33.src.rpm
golang-github-xiaq-persistent-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/xiaq/persistent/.goipath
golang-github-xiaq-persistent.src: W: no-%build-section
2 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
warning: Found bdb Packages database while attempting sqlite backend: using bdb
backend.
warning: Found bdb Packages database while attempting sqlite backend: using bdb
backend.
golang-github-xiaq-persistent-devel.noarch: W: invalid-url URL:
https://github.com/xiaq/persistent <urlopen error [Errno -2] Name or service
not known>
golang-github-xiaq-persistent-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/xiaq/persistent/.goipath
1 packages and 0 specfiles checked; 0 errors, 2 warnings.



Source checksums
----------------
https://github.com/xiaq/persistent/archive/a1d9ac4077fcad050b845856c51643c30795a171/persistent-a1d9ac4077fcad050b845856c51643c30795a171.tar.gz
:
  CHECKSUM(SHA256) this package     :
81bef02054bc2a1867daf64f55b281ef7f3bea077dfa4e4e7ac877ff4f5d0ece
  CHECKSUM(SHA256) upstream package :
462d6e6fd52d19467f1045fe1ffda2b6f33aced17afd389f4f9b95f91b8e5f54
diff -r also reports differences


Requires
--------
golang-github-xiaq-persistent-devel (rpmlib, GLIBC filtered):
    go-filesystem



Provides
--------
golang-github-xiaq-persistent-devel:
    golang(github.com/xiaq/persistent)
   
golang(github.com/xiaq/persistent)(commit=a1d9ac4077fcad050b845856c51643c30795a171)
    golang(github.com/xiaq/persistent/hash)
   
golang(github.com/xiaq/persistent/hash)(commit=a1d9ac4077fcad050b845856c51643c30795a171)
    golang(github.com/xiaq/persistent/hashmap)
   
golang(github.com/xiaq/persistent/hashmap)(commit=a1d9ac4077fcad050b845856c51643c30795a171)
    golang(github.com/xiaq/persistent/list)
   
golang(github.com/xiaq/persistent/list)(commit=a1d9ac4077fcad050b845856c51643c30795a171)
    golang(github.com/xiaq/persistent/vector)
   
golang(github.com/xiaq/persistent/vector)(commit=a1d9ac4077fcad050b845856c51643c30795a171)
    golang-github-xiaq-persistent-devel
    golang-ipath(github.com/xiaq/persistent)
   
golang-ipath(github.com/xiaq/persistent)(commit=a1d9ac4077fcad050b845856c51643c30795a171)



Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -b 1837793
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: R, fonts, Java, Haskell, Python, Ocaml, PHP, C/C++, Perl,
SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux