https://bugzilla.redhat.com/show_bug.cgi?id=1826621 --- Comment #19 from Neil Horman <nhorman@xxxxxxxxxx> --- New review looks good! Theres only two things left to handle: 1) I checked on the pem certificates, and I can't find any explicit rule about inclusion of pem certificates, so I think we're good, and as its marked as a conf file it should be replaceable without getting flagged as an rpm change post install, so I'm good there 2) The bundling of extra packages. I didn't fully comprehend how fedora implemented that. I was under the impression that bundled packages in golang could have an exception to download from the internet, but I was mistaken. The build system unilaterally disallows network access during builds, so its guaranteed to not be able to do that. When the docs say bundled, they mean included in the source rpm. Fortunately thats an easy fix. To correct that we need to: a) Take a snapshot of the packages that you need from the gopath after a clean install, and tar it up (I've taken the liberty of doing so for you here: https://people.redhat.com/nhorman/rpms/rmd-extra.pkgs.tbz2 Note that this is just a quick and dirty tarballing, and its about 400MB, you might be better off trying to pair that down a little if you can (I'm not sure if go allows you to trim out commit history to save space, but you can use it if need be. b) Modify the spec file as follows: [nhorman@hmswarspite SPECS]$ diff -u ~/1826621-rmd/srpm/rmd.spec ./rmd.spec --- /home/nhorman/1826621-rmd/srpm/rmd.spec 2020-05-19 13:51:10.014546923 -0400 +++ ./rmd.spec 2020-05-19 15:13:43.579637705 -0400 @@ -5,6 +5,7 @@ License: ASL 2.0 URL: https://github.com/intel/rmd Source0: https://github.com/arunprabhu123/rmd/blob/master/rmd-1.0.tar.gz +Source1: rmd-extra-pkgs.tbz2 BuildRequires: go BuildRequires: make @@ -61,8 +62,13 @@ %prep %setup -q - +mkdir app + %build +mkdir _pkg +tar -C _pkg -x -v -f %{SOURCE1} +find _pkg -type d -exec chmod 755 {} \; +export GOPATH=$PWD/_pkg:/usr/lib/golang make %{?_smp_mflags} %install This will place the extra packages you need in a subdir (the _pkg directory is created so go build ignores the path when running go build). We then explode the extra packages into that subdir, and ammend our GOPATH to point to it, so that can reference them without having to download them from the internet. Once thats done you should be good to go. I'm approving this review request, since you'll need to fix this before the package will build in koji. When you are ready please continue the fedora packaging process by requesting a repo be created for this package using the fedpkg request-repo command (see https://fedoraproject.org/wiki/Package_Review_Process) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
