[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1816295



--- Comment #2 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #1)
>  - License is GPLv2 not MIT:

Fixed

>  - Add BR gcc

Added

>  - Tests are not properly run:
> 
> + /usr/bin/python3 setup.py test
> running test
> running egg_info
> WARNING: Testing via this command is deprecated and will be removed in a
> future version. Users looking for a generic test entry point independent of
> test runner are encouraged to use tox.
> writing mysqlclient.egg-info/PKG-INFO
> writing dependency_links to mysqlclient.egg-info/dependency_links.txt
> writing top-level names to mysqlclient.egg-info/top_level.txt
> reading manifest file 'mysqlclient.egg-info/SOURCES.txt'
> reading manifest template 'MANIFEST.in'
> writing manifest file 'mysqlclient.egg-info/SOURCES.txt'
> running build_ext
> copying
> build/lib.linux-x86_64-3.8/MySQLdb/_mysql.cpython-38-x86_64-linux-gnu.so ->
> MySQLdb
> ----------------------------------------------------------------------
> Ran 0 tests in 0.000s
> 
> They seem to be run using Pytest, but they need a mysql server I think.

Yes, they need a DB instance. Add but not enabled by default.


%changelog
* Mon May 18 2020 Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> - 1.4.6-2
- Add tests and missing BR
- Fix license (rhbz#1816295)

Updated files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-mysqlclient.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-mysqlclient-1.4.6-2.fc31.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux