Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl-XML-Dumper https://bugzilla.redhat.com/show_bug.cgi?id=226284 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2007-10-22 03:21 EST ------- 1)perl as BR is not needed. mock build without it worked successfully. remove redundant dependency on perl >= 1:5.6.1 2)drop "|| :" from %check 3)you may like to keep simple disttag as "2%{dist}" only. 4)rpmlint only complained -> perl-XML-Dumper.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. ==> Use "sed -i -e 's|\t| |g' perl-XML-Dumper" perl-XML-Dumper.noarch: W: file-not-utf8 /usr/share/doc/perl-XML-Dumper-0.81/README The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). ==> use iconv command -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review