https://bugzilla.redhat.com/show_bug.cgi?id=1835263 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- The previous package review was bug #1183286. Url and Source0 addresses are Ok. Source0 archive (SHA-256: f390c6d84e289544a0f7bee9a9941bb34579cbf526df7c78eb77b3e177c78eea) is original. Ok. Summary verified from lib/Crypt/PWSafe3.pm. Ok. Description verified from lib/Crypt/PWSafe3.pm. Ok. License verified from README, lib/Crypt/PWSafe3/Field.pm, lib/Crypt/PWSafe3/PasswordPolicy.pm, lib/Crypt/PWSafe3/Databaseformat.pm, lib/Crypt/PWSafe3/SHA256.pm, lib/Crypt/PWSafe3/HeaderField.pm, lib/Crypt/PWSafe3/Record.pm, lib/Crypt/PWSafe3.pm, t/run.t, and Makefile.PL. Ok. No XS code, noarch BuildArch is Ok. FIX: Do not build-require 'findutils' and 'coreutils'. They are not used anywhere. TODO: Constrain 'perl(ExtUtils::MakeMaker)' dependency with '>= 6.76' because of the NO_PACKLIST=1, NO_PERLLOCAL=1 Makefile.PL arguments. All tests pass. OK. $ rpmlint perl-Crypt-PWSafe3.spec ../SRPMS/perl-Crypt-PWSafe3-1.22-12.fc33.src.rpm ../RPMS/noarch/perl-Crypt-PWSafe3-1.22-12.fc33.noarch.rpm ../RPMS/noarch/perl-Crypt-PWSafe3-1.22-12.fc33.noarch.rpm sh: /usr/bin/python2: No such file or directory perl-Crypt-PWSafe3.src: W: spelling-error %description -l en_US passwordsafe -> password safe, password-safe, password perl-Crypt-PWSafe3.noarch: W: spelling-error %description -l en_US passwordsafe -> password safe, password-safe, password perl-Crypt-PWSafe3.noarch: W: spelling-error %description -l en_US passwordsafe -> password safe, password-safe, password 3 packages and 1 specfiles checked; 0 errors, 3 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Crypt-PWSafe3-1.22-12.fc33.noarch.rpm drwxr-xr-x 2 root root 0 May 18 13:23 /usr/share/doc/perl-Crypt-PWSafe3 -rw-r--r-- 1 root root 4396 Mar 14 2016 /usr/share/doc/perl-Crypt-PWSafe3/CHANGELOG -rw-r--r-- 1 root root 1170 Mar 14 2016 /usr/share/doc/perl-Crypt-PWSafe3/README -rw-r--r-- 1 root root 3867 May 18 13:23 /usr/share/man/man3/Crypt::PWSafe3.3pm.gz -rw-r--r-- 1 root root 8688 May 18 13:23 /usr/share/man/man3/Crypt::PWSafe3::Databaseformat.3pm.gz -rw-r--r-- 1 root root 1728 May 18 13:23 /usr/share/man/man3/Crypt::PWSafe3::Field.3pm.gz -rw-r--r-- 1 root root 1876 May 18 13:23 /usr/share/man/man3/Crypt::PWSafe3::HeaderField.3pm.gz -rw-r--r-- 1 root root 1839 May 18 13:23 /usr/share/man/man3/Crypt::PWSafe3::PasswordPolicy.3pm.gz -rw-r--r-- 1 root root 2728 May 18 13:23 /usr/share/man/man3/Crypt::PWSafe3::Record.3pm.gz -rw-r--r-- 1 root root 1518 May 18 13:23 /usr/share/man/man3/Crypt::PWSafe3::SHA256.3pm.gz drwxr-xr-x 2 root root 0 May 18 13:23 /usr/share/perl5/vendor_perl/Crypt drwxr-xr-x 2 root root 0 May 18 13:23 /usr/share/perl5/vendor_perl/Crypt/PWSafe3 -rw-r--r-- 1 root root 24177 Mar 14 2016 /usr/share/perl5/vendor_perl/Crypt/PWSafe3.pm -rw-r--r-- 1 root root 20735 Nov 15 2012 /usr/share/perl5/vendor_perl/Crypt/PWSafe3/Databaseformat.pm -rw-r--r-- 1 root root 4427 Feb 16 2015 /usr/share/perl5/vendor_perl/Crypt/PWSafe3/Field.pm -rw-r--r-- 1 root root 4777 Feb 16 2015 /usr/share/perl5/vendor_perl/Crypt/PWSafe3/HeaderField.pm -rw-r--r-- 1 root root 4163 Feb 12 2015 /usr/share/perl5/vendor_perl/Crypt/PWSafe3/PasswordPolicy.pm -rw-r--r-- 1 root root 10235 May 21 2015 /usr/share/perl5/vendor_perl/Crypt/PWSafe3/Record.pm -rw-r--r-- 1 root root 1303 Feb 16 2015 /usr/share/perl5/vendor_perl/Crypt/PWSafe3/SHA256.pm A file layout and the permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Crypt-PWSafe3-1.22-12.fc33.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.2) 1 perl(:VERSION) >= 5.10.0 1 perl(Bytes::Random::Secure) 1 perl(Carp) 1 perl(Carp::Heavy) 1 perl(Config) 1 perl(Crypt::CBC) >= 2.3 1 perl(Crypt::ECB) >= 1.45 1 perl(Crypt::PWSafe3::Field) 1 perl(Crypt::PWSafe3::HeaderField) 1 perl(Crypt::PWSafe3::PasswordPolicy) 1 perl(Crypt::PWSafe3::Record) 1 perl(Crypt::PWSafe3::SHA256) 1 perl(Crypt::Random) >= 1.25 1 perl(Crypt::Twofish) >= 2.14 1 perl(Data::Dumper) 1 perl(Data::UUID) >= 1.22 1 perl(Digest::HMAC) >= 1 1 perl(Digest::SHA) >= 1 1 perl(Exporter) 1 perl(File::Copy) 1 perl(File::Spec) 1 perl(File::Temp) 1 perl(FileHandle) 1 perl(strict) 1 perl(utf8) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Bytes::Random::Secure is optional, Crypt::Random is a fallback. Change the 'perl(Bytes::Random::Secure)' from Requires to Recommends. $ rpm -q --provides -p ../RPMS/noarch/perl-Crypt-PWSafe3-1.22-12.fc33.noarch.rpm | sort -f | uniq -c 1 perl(Crypt::PWSafe3) = 1.22 1 perl(Crypt::PWSafe3::Field) = 1.06 1 perl(Crypt::PWSafe3::HeaderField) = 1.05 1 perl(Crypt::PWSafe3::PasswordPolicy) = 1.01 1 perl(Crypt::PWSafe3::Record) = 1.10 1 perl(Crypt::PWSafe3::SHA256) = 1.03 1 perl-Crypt-PWSafe3 = 1.22-12.fc33 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Crypt-PWSafe3-1.22-12.fc33.noarch.rpm Binary dependencies are resolvable. Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all the 'FIX' items, and consider fixing the 'TODO' items before building this package. The package builds in Fedora 33 (https://koji.fedoraproject.org/koji/taskinfo?taskID=44646874). Ok. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
