https://bugzilla.redhat.com/show_bug.cgi?id=1834977 --- Comment #2 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- (In reply to Carl George 🤠 from comment #1) > [!]: License field in the package spec file matches the actual license. > > The COPYING file contains the MPLv1.1, the GPLv2, and the LGPLv2. The > setup.py file also lists all three of these licenses. Include them all in > the License field. > > -License: MPLv1.1 > +License: MPLv1.1 or GPLv2 or LGPLv2 Fixed > > ===== SHOULD fix ===== > > [!]: %check is present and all tests pass. > > There is an upstream test suite and it passes, but running it would build > require a deprecated package (python3-nose). I only bring it up to > encourage you to engage upstream about removing that dependency, and link to > the upstream discussion in a comment in the spec file. They only thing they > are using specifically from nose is nose.tools.eq_. > > https://github.com/PyYoshi/cChardet/blob/2.1.6/src/tests/test.py#L6 > https://nose.readthedocs.io/en/latest/testing_tools.html#nose.tools.eq_ Upstream issue created to get a response from upstream. %changelog * Sun May 17 2020 Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> - 2.1.6-2 - Add comment about nose - Update license tag (rhbz#1834977) Update files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-cchardet.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-cchardet-2.1.6-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
