[Bug 1822971] Review Request: notcurses - character graphics and TUI library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1822971



--- Comment #62 from David Cantrell <dcantrell@xxxxxxxxxx> ---
In that situation isn't the .egg-info not being a directory caught by this line
in %files:

    %{python3_sitearch}/*egg-info/

The trailing slash tells RPM that it expects that glob to be a directory.  I
just tried it out locally where I did:

    echo "testing file" > %{buildroot}%{python3_sitearch}/blurfle

And put this in %files:

    %{python3_sitearch}/blurfle/

An 'rpmbuild -ba' gave me:

    RPM build errors:
        Not a directory:
/home/dcantrell/rpmbuild/BUILDROOT/notcurses-1.3.0-1.fc31.x86_64/usr/lib64/python3.7/site-packages/blurfle

With an exit code of 1.

We have both the recommendation for "BuildRequires: python3-setuptools" as well
as the %files entry for the egg-info directory in the Fedora packaging guide. 
Even without setuptools as a BR, the %files entry still guards the build.

Good point and worth noting for other language ecosystems that have package
managers and module systems of their own.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux