[Bug 1834280] Review Request: ilua - Portable Lua kernel for Jupyter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1834280



--- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
(In reply to thrnciar from comment #1)
> - Packages MUST NOT have dependencies (either build-time or runtime) on
>   packages named with the unversioned python- prefix unless no properly
>   versioned package exists. Dependencies on Python packages instead MUST
>   use names beginning with python2- or python3- as appropriate.
>   Note: Unversionned Python dependency found.
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/Python/#_dependencies

python-jupyter-filesystem is a Python version agnostic package. There is no
python3-jupyter-filesystem to depend on. FedoraReview is wrong here.

> - If (and only if) the source package includes the text of the license(s)
>   in its own file, then that file, containing the text of the license(s)
>   for the package is included in %license.
>   Note: License file logo-license.txt is not marked as %license
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/LicensingGuidelines/#_license_text

logo-license.txt is the license of the logo. I think it needs to be marked with
%license and I also need to check what license the logo actually is.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux