https://bugzilla.redhat.com/show_bug.cgi?id=1830306 --- Comment #3 from Ian McInerney <ian.s.mcinerney@xxxxxxxx> --- Updated spec file: https://download.copr.fedorainfracloud.org/results/imcinerney/git-revise/fedora-32-x86_64/01381895-git-revise/git-revise.spec Updated SRPM: https://download.copr.fedorainfracloud.org/results/imcinerney/git-revise/fedora-32-x86_64/01381895-git-revise/git-revise-0.5.1-2.fc32.src.rpm > The checksum of the tarball in the SRPM and upstream doesn't match. Please make sure the SRPM is updated. Apparently it was still using the PyPi version that I initially made the spec using (but then modified to use the non-PyPi version). Fixed now. > You might want to rename the tarball using the Source URL as: https://github.com/mystor/git-revise/archive/%{version}/%{name}-%{version}.tar.gz but that's up to you. Fixed. > Why does it require setuptools? It should be a BuildRequires only. That was added in by the pypi2rpm generator when I first ran it, so I guess it thought it was needed. I agree, it shouldn't be there though. > Please, open a bug report upstream with the included patch and reference it in the spec file. Done. > This should also be "BuildArch: noarch", which will remove the need for disabling debuginfo subpackage. I already had it as noarch in the spec, it's just I was concerned by the line + /usr/lib/rpm/find-debuginfo.sh -j12 --strict-build-id -m -i --build-id-seed 0.5.1-2.fc32 --unique-debug-suffix -0.5.1-2.fc32.x86_64 --unique-debug-src-base git-revise-0.5.1-2.fc32.x86_64 --run-dwz --dwz-low-mem-die-limit 10000000 --dwz-max-die-limit 110000000 -S debugsourcefiles.list /builddir/build/BUILD/git-revise-0.5.1 find: 'debug': No such file or directory" when running a mock build. I have removed that line now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
