https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #17 from dan.cermak@xxxxxxxxxxxxxxxxxxx --- A few additional notes: - Requires(post): /sbin/install-info is not required, the same is the case for Requires(post/postun): /sbin/ldconfig. - %setup -q -> %autosetup - make %{?_smp_mflags} -> %make_build - make install DESTDIR=$RPM_BUILD_ROOT -> %make_install - $RPM_BUILD_ROOT -> %{buildroot} - $RPM_OPT_FLAGS -> %optflags or %build_cflags - there are headers and a shared library in the main package, these usually belong into -devel subpackages - libcob.so is included in the libcob subpackage via a wildcard, this is strongly discouraged as that hides the SONAME - You appear to be packaging the nightly release, why? Since there is no stable URL to that, this makes reproducability complicated. - The Requires: glibc-devel and gmp-devel should not be required, rpm finds out by itself that libcob requires libc, libgmp and libm - Your package does not own %{_libdir}/%{name}, but creates it. - cob-config is a static executable, which is afaik not permitted in Fedora -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
