https://bugzilla.redhat.com/show_bug.cgi?id=1831863 --- Comment #3 from Richard Shaw <hobbes1069@xxxxxxxxx> --- (In reply to Jaroslav Škarvada from comment #2) > - please rename the package from the generic lpcnet to some better name > > - %{bindir} owned, please use %{_bindir}/* to own the files Whoops, fixed. > - lpcnet.x86_64: W: shared-lib-calls-exit /usr/lib64/liblpcnetfreedv.so > exit@GLIBC_2.2.5 > I think API shouldn't do it, please report upstream whether there is any > reason for it (this is not Fedora blocker). I'll let David know. > - lpcnet.x86_64: E: invalid-soname /usr/lib64/liblpcnetfreedv.so > It should have soname, see: > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_downstream_so_name_versioning Wow, hadn't caught that made it into the guidelines. I may put the library in a subdir and consider it "private" as the only intended (direct) consumer is FreeDV. > - unversioned lib link (liblpcnetfreedv.so) should be in the -devel package > > - please provide comment for the patch (lpcnet-vector-updates.patch) purpose > and whether it was sent upstream (upstream link if available) Done. I'll ping David and once confirmed which way to go with the library I'll pose new spec/srpm. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
