https://bugzilla.redhat.com/show_bug.cgi?id=1824848 --- Comment #22 from Kelly Brazil <kellyjonbrazil@xxxxxxxxx> --- I have updated the upstream source and spec and rebuilt the SRPM per the above. rpmlint is coming back clean: Issues: ======= - The spec produces a python binary in a "python3-jc" package, instead of just "jc". "python3-XXX" is only required for python modules. I think I have fixed this, but not exactly sure how to test if this is fixed. Also, jc can be used as a python module but will probably be used as a CLI utility 99% of the time. When I tried to change all references of "python3-%{pypi_name}" to "%{pypi_name}", rpm gave me the error: "error: line 24: %package -n jc: package jc already exists" So I reverted those back to "python3-%{pypi_name}". - Spec file name must match the spec package %{name}, in the format %{name}.spec - "python-jc.spec" should be "jc.spec". Fixed - Upstream sources contain a test suite, but the spec does not contain a %check section that would execute those tests. Fixed - I removed the tests from the upstream (pypi) since the fixtures were quite large. - There are extra executable bits on README.md and LICENSE.md. Fixed - removed executable bits. https://raw.githubusercontent.com/kellyjonbrazil/jc-packaging/master/rpmbuild/SPEC/jc.spec https://jc-packages.s3-us-west-1.amazonaws.com/fedora/jc-1.10.12-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
