https://bugzilla.redhat.com/show_bug.cgi?id=1831863 Jaroslav Škarvada <jskarvad@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- - please rename the package from the generic lpcnet to some better name - %{bindir} owned, please use %{_bindir}/* to own the files - lpcnet.x86_64: W: shared-lib-calls-exit /usr/lib64/liblpcnetfreedv.so exit@GLIBC_2.2.5 I think API shouldn't do it, please report upstream whether there is any reason for it (this is not Fedora blocker). - lpcnet.x86_64: E: invalid-soname /usr/lib64/liblpcnetfreedv.so It should have soname, see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning - unversioned lib link (liblpcnetfreedv.so) should be in the -devel package - please provide comment for the patch (lpcnet-vector-updates.patch) purpose and whether it was sent upstream (upstream link if available) - different SRPM/spec: --- lpcnet/srpm/lpcnet.spec 2020-05-10 20:40:21.330052406 +0200 +++ lpcnet/srpm-unpacked/lpcnet.spec 2020-04-22 17:56:42.000000000 +0200 @@ -39,7 +39,10 @@ # We need to force optimizations to specific values since the build system and # host system will likely be different. -%ifarch i68 x86_64 +%ifarch x86_64 %global _cpuopt "-DAVX2=TRUE" %endif +%ifarch i686 + %global _cpuopt "-DAVX=TRUE" +%endif %ifarch armv7hl %global _cpuopt "-DNEON=TRUE" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
