https://bugzilla.redhat.com/show_bug.cgi?id=1833511 --- Comment #3 from Brandon Perkins <bperkins@xxxxxxxxxx> --- In my own review of fedora-review package, I didn't notice much. There were no failures. > ===== MUST items ===== > > Generic: > [ ]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. License : ASL 2.0 $ rpm -qL golang-github-dustinkirkland-petname /usr/share/licenses/golang-github-dustinkirkland-petname/LICENSE $ head -5 /usr/share/licenses/golang-github-dustinkirkland-petname/LICENSE Apache License Version 2.0, January 2004 http://www.apache.org/licenses/ > [ ]: License field in the package spec file matches the actual license. $ licensecheck /usr/share/licenses/golang-github-dustinkirkland-petname/LICENSE /usr/share/licenses/golang-github-dustinkirkland-petname/LICENSE: *No copyright* Apache License (v2.0) > [ ]: License file installed when any subpackage combination is installed. See discussion at https://bugzilla.redhat.com/show_bug.cgi?id=1773720#c10 > [ ]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: > /usr/share/gocode/src/github.com All go packages "own" this directory > [ ]: %build honors applicable compiler flags or justifies otherwise. > [ ]: Package contains no bundled libraries without FPC exception. > [ ]: Changelog in prescribed format. > [ ]: Sources contain only permissible code or content. All okay > [ ]: Package contains desktop file if it is a GUI application. N/A > [ ]: Development files must be in a -devel package > [ ]: Package uses nothing in %doc for runtime. > [ ]: Package consistently uses macros (instead of hard-coded directory > names). > [ ]: Package is named according to the Package Naming Guidelines. > [ ]: Package does not generate any conflict. > [ ]: Package obeys FHS, except libexecdir and /usr/target. > [ ]: If the package is a rename of another package, proper Obsoletes and > Provides are present. > [ ]: Requires correct, justified where necessary. > [ ]: Spec file is legible and written in American English. All okay > [ ]: Package contains systemd file(s) if in need. N/A > [ ]: Useful -debuginfo package or justification otherwise. > [ ]: Package is not known to require an ExcludeArch tag. Both okay > [ ]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 40960 bytes in 4 files. Not needed > [ ]: Package complies to the Packaging Guidelines > [x]: Package successfully compiles and builds into binary rpms on at least > one supported primary architecture. > [x]: Package installs properly. > [x]: Rpmlint is run on all rpms the build produces. > Note: There are rpmlint messages (see attachment). Checking: golang-github-dustinkirkland-petname-debuginfo-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > [x]: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %license. > [x]: Package requires other packages for directories it uses. > [x]: Package must own all directories that it creates. > [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT > [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > [x]: Macros in Summary, %description expandable at SRPM build time. > [x]: Dist tag is present. > [x]: Package does not contain duplicates in %files. > [x]: Permissions on files are set properly. > [x]: Package must not depend on deprecated() packages. > [x]: Package use %makeinstall only when make install DESTDIR=... doesn't > work. > [x]: Package is named using only allowed ASCII characters. > [x]: Package does not use a name that already exists. > [x]: Package is not relocatable. > [x]: Sources used to build the package match the upstream source, as > provided in the spec URL. > [x]: Spec file name must match the spec package %{name}, in the format > %{name}.spec. > [x]: File names are valid UTF-8. > [x]: Packages must not store files under /srv, /opt or /usr/local > > ===== SHOULD items ===== > > Generic: > [ ]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. $ tar -tvzf SOURCES/golang-petname-8e5a1ed0cff0384869564ec1c086c6467a025667.tar.gz golang-petname-8e5a1ed0cff0384869564ec1c086c6467a025667/LICENSE -rw-rw-r-- root/root 11358 2019-11-29 16:52 golang-petname-8e5a1ed0cff0384869564ec1c086c6467a025667/LICENSE > [ ]: Final provides and requires are sane (see attachments). Okay > [ ]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- > github-dustinkirkland-petname-devel Okay > [ ]: Package functions as described. Yes, see comment 2 > [ ]: Latest version is packaged. > [ ]: Package does not include license text files separate from upstream. > [ ]: Sources are verified with gpgverify first in %prep if upstream > publishes signatures. > Note: gpgverify is not used. All okay > [ ]: Description and summary sections in the package spec file contains > translations for supported Non-English languages, if available. N/A > [ ]: %check is present and all tests pass. > [ ]: Packages should try to preserve timestamps of original installed > files. Both okay > [x]: Reviewer should test that the package builds in mock. > [x]: Buildroot is not present > [x]: Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. > [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file > [x]: Sources can be downloaded from URI in Source: tag > [x]: SourceX is a working URL. > [x]: Package should compile and build into binary rpms on all supported > architectures. > [x]: Spec use %global instead of %define unless justified. > > ===== EXTRA items ===== > > Generic: > [x]: Rpmlint is run on debuginfo package(s). > Note: No rpmlint messages. > [x]: Rpmlint is run on all installed packages. > Note: There are rpmlint messages (see attachment). > [x]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > [x]: Spec file according to URL is the same as in SRPM. > > > Rpmlint > ------- > Checking: golang-github-dustinkirkland-petname-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm > golang-github-dustinkirkland-petname-devel-0-0.1.20200508git8e5a1ed.fc33.noarch.rpm > golang-github-dustinkirkland-petname-debuginfo-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm > golang-github-dustinkirkland-petname-debugsource-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm > golang-github-dustinkirkland-petname-0-0.1.20200508git8e5a1ed.fc33.src.rpm > golang-github-dustinkirkland-petname-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dustinkirkland/golang-petname/.goipath > golang-github-dustinkirkland-petname-debugsource.x86_64: E: description-line-too-long C This package provides debug sources for package golang-github-dustinkirkland-petname. > 5 packages and 0 specfiles checked; 1 errors, 1 warnings. > All expected > > > > Rpmlint (debuginfo) > ------------------- > Checking: golang-github-dustinkirkland-petname-debuginfo-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm > 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > > > > > > Rpmlint (installed packages) > ---------------------------- > golang-github-dustinkirkland-petname-devel.noarch: W: invalid-url URL: https://github.com/dustinkirkland/golang-petname <urlopen error [Errno -2] Name or service not known> > golang-github-dustinkirkland-petname-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dustinkirkland/golang-petname/.goipath > golang-github-dustinkirkland-petname-debuginfo.x86_64: W: invalid-url URL: https://github.com/dustinkirkland/golang-petname <urlopen error [Errno -2] Name or service not known> > golang-github-dustinkirkland-petname-debugsource.x86_64: E: description-line-too-long C This package provides debug sources for package golang-github-dustinkirkland-petname. > golang-github-dustinkirkland-petname-debugsource.x86_64: W: invalid-url URL: https://github.com/dustinkirkland/golang-petname <urlopen error [Errno -2] Name or service not known> > golang-github-dustinkirkland-petname.x86_64: W: invalid-url URL: https://github.com/dustinkirkland/golang-petname <urlopen error [Errno -2] Name or service not known> > 4 packages and 0 specfiles checked; 1 errors, 5 warnings. > All expected > > > Source checksums > ---------------- > https://github.com/dustinkirkland/golang-petname/archive/8e5a1ed0cff0384869564ec1c086c6467a025667/golang-petname-8e5a1ed0cff0384869564ec1c086c6467a025667.tar.gz : > CHECKSUM(SHA256) this package : 29550cf760595d7c022cd04facd9ef81261953f53b5d8d18ca6cbe432f92fba3 > CHECKSUM(SHA256) upstream package : 29550cf760595d7c022cd04facd9ef81261953f53b5d8d18ca6cbe432f92fba3 > > > Requires > -------- > golang-github-dustinkirkland-petname (rpmlib, GLIBC filtered): > libc.so.6()(64bit) > libpthread.so.0()(64bit) > rtld(GNU_HASH) > > golang-github-dustinkirkland-petname-devel (rpmlib, GLIBC filtered): > go-filesystem > > golang-github-dustinkirkland-petname-debuginfo (rpmlib, GLIBC filtered): > > golang-github-dustinkirkland-petname-debugsource (rpmlib, GLIBC filtered): > > > > Provides > -------- > golang-github-dustinkirkland-petname: > golang-github-dustinkirkland-petname > golang-github-dustinkirkland-petname(x86-64) > > golang-github-dustinkirkland-petname-devel: > golang(github.com/dustinkirkland/golang-petname) > golang(github.com/dustinkirkland/golang-petname)(commit=8e5a1ed0cff0384869564ec1c086c6467a025667) > golang-github-dustinkirkland-petname-devel > golang-ipath(github.com/dustinkirkland/golang-petname) > golang-ipath(github.com/dustinkirkland/golang-petname)(commit=8e5a1ed0cff0384869564ec1c086c6467a025667) > > golang-github-dustinkirkland-petname-debuginfo: > debuginfo(build-id) > golang-github-dustinkirkland-petname-debuginfo > golang-github-dustinkirkland-petname-debuginfo(x86-64) > > golang-github-dustinkirkland-petname-debugsource: > golang-github-dustinkirkland-petname-debugsource > golang-github-dustinkirkland-petname-debugsource(x86-64) > > > > Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 > Command line :/usr/bin/fedora-review -L /home/bperkins/git/haproxytech/RPMS -b 1833511 > Buildroot used: fedora-rawhide-x86_64 > Active plugins: Generic, Shell-api > Disabled plugins: Haskell, Java, fonts, C/C++, Python, R, Perl, SugarActivity, Ocaml, PHP > Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH > > Built with local dependencies: > /home/bperkins/git/haproxytech/RPMS/golang-github-dustinkirkland-petname-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm > /home/bperkins/git/haproxytech/RPMS/golang-github-dustinkirkland-petname-devel-0-0.1.20200508git8e5a1ed.fc33.noarch.rpm > /home/bperkins/git/haproxytech/RPMS/golang-github-dustinkirkland-petname-debugsource-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm > /home/bperkins/git/haproxytech/RPMS/golang-github-dustinkirkland-petname-debuginfo-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm > /home/bperkins/git/haproxytech/RPMS/golang-github-gehirninc-crypt-devel-0-0.3.20200415gitbb7000b.fc33.noarch.rpm > /home/bperkins/git/haproxytech/RPMS/golang-github-haproxytech-client-native-devel-2.0.1-1.fc33.noarch.rpm > /home/bperkins/git/haproxytech/RPMS/compat-golang-github-haproxytech-client-native-2-devel-2.0.1-1.fc33.noarch.rpm > /home/bperkins/git/haproxytech/RPMS/golang-github-haproxytech-config-parser-devel-2.0.1-1.fc33.noarch.rpm > /home/bperkins/git/haproxytech/RPMS/compat-golang-github-haproxytech-config-parser-2-devel-2.0.1-1.fc33.noarch.rpm > /home/bperkins/git/haproxytech/RPMS/golang-github-haproxytech-dataplaneapi-2.0.1-1.fc33.x86_64.rpm > /home/bperkins/git/haproxytech/RPMS/golang-github-haproxytech-dataplaneapi-debuginfo-2.0.1-1.fc33.x86_64.rpm > /home/bperkins/git/haproxytech/RPMS/compat-golang-github-haproxytech-dataplaneapi-2-devel-2.0.1-1.fc33.noarch.rpm > /home/bperkins/git/haproxytech/RPMS/golang-github-haproxytech-dataplaneapi-debugsource-2.0.1-1.fc33.x86_64.rpm > /home/bperkins/git/haproxytech/RPMS/golang-github-haproxytech-dataplaneapi-devel-2.0.1-1.fc33.noarch.rpm > /home/bperkins/git/haproxytech/RPMS/compat-golang-github-haproxytech-models-2-devel-2.0.1-1.fc33.noarch.rpm > /home/bperkins/git/haproxytech/RPMS/golang-github-haproxytech-models-devel-2.0.1-1.fc33.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
