https://bugzilla.redhat.com/show_bug.cgi?id=1832623 --- Comment #8 from Stuart D Gathman <stuart@xxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in psi-notify See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Reviewer note: the user service is enabled by default for all users. I can see the reason for this (we are installing an extension to the desktop environments), but maybe the description should mention this. - the (one) source file does not have a copyright in the source. Advise upstream to include a copyright notice and reference the license in the source. Or is this no longer recommended? - Technically there should be a Requires: systemd - although this seems rather pedantic as all Fedora systems, including EPEL as of Nov, have systemd. Maybe this is a bug in fedora-review. It complains that e.g. /usr/lib/systemd has no documented owner. - Should demo.gif be included in %doc ? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 6 files have unknown license. Detailed output of licensecheck in /home/stuart/fedora- scm/psi-notify/review-psi-notify/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd, /usr/lib/systemd/user [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: psi-notify-1.0.1-1.fc32.x86_64.rpm psi-notify-debuginfo-1.0.1-1.fc32.x86_64.rpm psi-notify-debugsource-1.0.1-1.fc32.x86_64.rpm psi-notify-1.0.1-1.fc32.src.rpm psi-notify.x86_64: W: no-manual-page-for-binary psi-notify 4 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (debuginfo) ------------------- Checking: psi-notify-debuginfo-1.0.1-1.fc32.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- psi-notify-debugsource.x86_64: W: invalid-url URL: https://github.com/cdown/psi-notify <urlopen error [Errno -2] Name or service not known> psi-notify-debuginfo.x86_64: W: invalid-url URL: https://github.com/cdown/psi-notify <urlopen error [Errno -2] Name or service not known> psi-notify.x86_64: W: invalid-url URL: https://github.com/cdown/psi-notify <urlopen error [Errno -2] Name or service not known> psi-notify.x86_64: W: no-manual-page-for-binary psi-notify 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Source checksums ---------------- https://github.com/cdown/psi-notify/archive/1.0.1.tar.gz#/psi-notify-1.0.1.tar.gz : CHECKSUM(SHA256) this package : e3cb4a6dcea3c6541e1884235d4c6c445f1a0486bd3e9cad660af31b795b25b8 CHECKSUM(SHA256) upstream package : e3cb4a6dcea3c6541e1884235d4c6c445f1a0486bd3e9cad660af31b795b25b8 Requires -------- psi-notify (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libnotify.so.4()(64bit) libpthread.so.0()(64bit) libsystemd.so.0()(64bit) libsystemd.so.0(LIBSYSTEMD_209)(64bit) rtld(GNU_HASH) psi-notify-debuginfo (rpmlib, GLIBC filtered): psi-notify-debugsource (rpmlib, GLIBC filtered): Provides -------- psi-notify: psi-notify psi-notify(x86-64) psi-notify-debuginfo: debuginfo(build-id) psi-notify-debuginfo psi-notify-debuginfo(x86-64) psi-notify-debugsource: psi-notify-debugsource psi-notify-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -m fedora-32-x86_64 -p -n psi-notify Buildroot used: fedora-32-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Python, Haskell, R, PHP, SugarActivity, Ocaml, Perl, Java, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
