Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl-URI https://bugzilla.redhat.com/show_bug.cgi?id=226283 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora ------- Additional Comments From panemade@xxxxxxxxx 2007-10-20 08:56 EST ------- 1)perl as BR is not needed. mock build without it worked successfully. remove redundant dependency on perl >= 1:5.6.1 2)drop "|| :" from %check 3) make test output skipped one test t/urn-isbn.......skipped all skipped: Needs the Business::ISBN module installed I think you need to add that(Business::ISBN) perl module as BR 4)rpmlint complained -> perl-URI.noarch: W: file-not-utf8 /usr/share/doc/perl-URI-1.35/Changes The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). ==> Use iconv command perl-URI.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. ==> Use sed perl-URI.src: W: strange-permission filter-requires-perl-URI.sh 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. ==> This can be Ignored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review