https://bugzilla.redhat.com/show_bug.cgi?id=1830322 --- Comment #1 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Looks good. fedora-review picked some additional licenses in the code, so once those are double-checked, this will be good to go :) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [-]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. ^ False positive. OK for gap packages. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "GPL (v2 or later)", "FSF Unlimited License (with Retention) GNU General Public License (v2)", "FSF Unlimited License (with Retention)", "Public domain". 211 files have unknown license. Detailed output of licensecheck in /home/asinha/dump/fedora-reviews/1830322-gap-pkg- ferret/licensecheck.txt ^ Please double check these to confirm what the license field should be. [-]: License file installed when any subpackage combination is installed. ^ No license file. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. ^ Is this worth looking into? [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. ^ Not tested this. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gap-pkg-ferret-1.0.2-1.fc33.x86_64.rpm gap-pkg-ferret-doc-1.0.2-1.fc33.x86_64.rpm gap-pkg-ferret-debuginfo-1.0.2-1.fc33.x86_64.rpm gap-pkg-ferret-debugsource-1.0.2-1.fc33.x86_64.rpm gap-pkg-ferret-1.0.2-1.fc33.src.rpm gap-pkg-ferret.x86_64: W: spelling-error %description -l en_US reimplementation -> re implementation, re-implementation, implementation gap-pkg-ferret.x86_64: W: spelling-error %description -l en_US tuples -> letups gap-pkg-ferret-doc.x86_64: W: only-non-binary-in-usr-lib gap-pkg-ferret-doc.x86_64: W: no-documentation gap-pkg-ferret.src: W: spelling-error %description -l en_US reimplementation -> re implementation, re-implementation, implementation gap-pkg-ferret.src: W: spelling-error %description -l en_US tuples -> letups 5 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (debuginfo) ------------------- Checking: gap-pkg-ferret-debuginfo-1.0.2-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- gap-pkg-ferret-debuginfo.x86_64: W: invalid-url URL: https://gap-packages.github.io/ferret/ <urlopen error [Errno -2] Name or service not known> gap-pkg-ferret-debugsource.x86_64: W: invalid-url URL: https://gap-packages.github.io/ferret/ <urlopen error [Errno -2] Name or service not known> gap-pkg-ferret-doc.x86_64: W: invalid-url URL: https://gap-packages.github.io/ferret/ <urlopen error [Errno -2] Name or service not known> gap-pkg-ferret-doc.x86_64: W: only-non-binary-in-usr-lib gap-pkg-ferret-doc.x86_64: W: no-documentation gap-pkg-ferret.x86_64: W: spelling-error %description -l en_US reimplementation -> re implementation, re-implementation, implementation gap-pkg-ferret.x86_64: W: spelling-error %description -l en_US tuples -> letups gap-pkg-ferret.x86_64: W: invalid-url URL: https://gap-packages.github.io/ferret/ <urlopen error [Errno -2] Name or service not known> 4 packages and 0 specfiles checked; 0 errors, 8 warnings. Unversioned so-files -------------------- gap-pkg-ferret: /usr/lib/gap/pkg/ferret-1.0.2/bin/x86_64-redhat-linux-gnu-default64-kv7/ferret.so ^ This is OK for gap packages. Source checksums ---------------- https://github.com/gap-packages/ferret/releases/download/v1.0.2/ferret-1.0.2.tar.gz : CHECKSUM(SHA256) this package : a1ef5cbc51ac345ba8bec82d846199b828034c23843f60e9e0704b81bd90ddf7 CHECKSUM(SHA256) upstream package : a1ef5cbc51ac345ba8bec82d846199b828034c23843f60e9e0704b81bd90ddf7 Requires -------- gap-pkg-ferret (rpmlib, GLIBC filtered): gap-core(x86-64) ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) gap-pkg-ferret-doc (rpmlib, GLIBC filtered): gap-pkg-ferret gap-pkg-ferret-debuginfo (rpmlib, GLIBC filtered): gap-pkg-ferret-debugsource (rpmlib, GLIBC filtered): Provides -------- gap-pkg-ferret: gap-pkg-ferret gap-pkg-ferret(x86-64) gap-pkg-ferret-doc: gap-pkg-ferret-doc gap-pkg-ferret-doc(x86-64) gap-pkg-ferret-debuginfo: debuginfo(build-id) gap-pkg-ferret-debuginfo gap-pkg-ferret-debuginfo(x86-64) gap-pkg-ferret-debugsource: gap-pkg-ferret-debugsource gap-pkg-ferret-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1830322 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Perl, Java, Python, Haskell, Ocaml, R, SugarActivity, PHP, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
