Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ccsm - Plugin and configuration tool - Compiz Fusion Project https://bugzilla.redhat.com/show_bug.cgi?id=328981 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-10-20 07:30 EST ------- For 0.6.0-0.3.XXXX: ! rpmlint issue: ------------------------------------------------------- # rpmlint ccsm ccsm.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/ccm/Constants.py 0644 ccsm.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/ccm/Conflicts.py 0644 ccsm.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/ccm/Settings.py 0644 ccsm.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/ccm/Widgets.py 0644 ccsm.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/ccm/Window.py 0644 ccsm.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/ccm/Utils.py 0644 ccsm.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/ccm/Pages.py 0644 ccsm.noarch: E: invalid-desktopfile /usr/share/applications/ccsm.desktop -------------------------------------------------------- * non-executable-script - These files have shebangs but do not have executable permissions. So either - remove shebangs from these files (for this package, this should be applied) - or set executable permissions on these files. * invalid-desktopfile - First, desktop file must be installed by desktop-file-install (BR: desktop-file-utils is needed). Please refer to the section "Desktop files" of http://fedoraproject.org/wiki/Packaging/Guidelines You can use "--delete-original" option - And this desktop file is invalid. -------------------------------------------------------- # desktop-file-validate /usr/share/applications/ccsm.desktop /usr/share/applications/ccsm.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated /usr/share/applications/ccsm.desktop: error: value "Compiz;Settings;DesktopSettings;" for key "Categories" in group "Desktop Entry" contains an unregistered value "Compiz" -------------------------------------------------------- Here "Encoding" entry can be there, however "Compiz" category is invalid and this should be removed (you can use "--remove-category" option). ! setup.py - Not a blocker, however I prefer "python setup.py build", for example. * Directory ownership issue - Please make it sure that all directories created by this package are correctly owned by this package. -------------------------------------------------------- %{_datadir}/ccsm/ %{_datadir}/ccsm/images/ %{python_sitelib}/ccm/ -------------------------------------------------------- ! Note: When you write -------------------------------------------------------- %files %{_datadir}/ccsm/ -------------------------------------------------------- This contains the directory %_datadir/ccsm itself and all files/directories under %_datadir/ccsm, while when you write -------------------------------------------------------- %files %dir %{_datadir}/ccsm/ -------------------------------------------------------- This contains the directory %_datadir/ccsm only. * Documents - As said in another review request, "INSTALL" file is usually not needed. * Calling update-desktop-database - is needed when desktop files to be installed in this package have Mimetype keys (c.f. section "desktop-database" of http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review