https://bugzilla.redhat.com/show_bug.cgi?id=1824848 --- Comment #12 from Artur Iwicki <fedora@xxxxxxxxxx> --- >https://github.com/kellyjonbrazil/jc-packaging/blob/master/rpmbuild/SPEC/python-jc.spec This points to a syntax-highlighted HTML rendition of the spec. Please use "raw file" links. >%global desc JSON CLI output utility. JC is used to JSONify the output of many standard linux \ >CLI tools and file types for easier parsing in scripts. This macro is later used for the %description and the first line is 81 characters long. Either remove the space at the end ("linux\") so it's exactly 80 characters, or move a word or two to the second line. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description >Name: python-%{pypi_name} jc is a Python application, not a library. As such, it's not necessary to use "python-jc" for the name; it can be just "jc". https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming The rest looks good to me. I'll do a proper review in the upcoming days. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
