https://bugzilla.redhat.com/show_bug.cgi?id=1822509 Lyes Saadi <fedora@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Lyes Saadi <fedora@xxxxxxx> --- Hi Bob! Yes, I also think about reviewing this package :P! But I stumbled upon a weird rule (Yes! Another time :P!): > If a package contains a GUI application, then it needs to also include a > properly installed .desktop file. For the purposes of these guidelines, a GUI > application is defined as any application which draws an X window and runs > from within that window. (Yes it says X window, but I imagine it also applies to a Wayland window :P) I am a bit confused by this and I shouldn't think a desktop file should be added... for the obvious reason that lavalauncher needs arguments to be passed so it works. So I got back to the beginnings of the Guidelines: > The Packaging Guidelines are a collection of common issues and the severity > that should be placed on them. While these guidelines should not be ignored, > they should also not be blindly followed. If you think that your package should > be exempt from part of the Guidelines, please bring the issue to the Fedora > Packaging Committee[1]. > Where the language "must", "is required to" or "needs to" is used, the packager > may deviate from the guideline only with approval from the packaging committee. > Please follow the procedure at the Packaging Committee[2] page for making these > requests. [1]: https://pagure.io/packaging-committee [2]: https://fedoraproject.org/wiki/Packaging_Committee#Bringing_Issues_to_the_Committee So, what do you think? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
