[Bug 1830310] Review Request: rust-pipe - Synchronous Read/Write memory pipe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1830310



--- Comment #4 from Robert Fairley <rfairley@xxxxxxxxxx> ---
(In reply to Dusty Mabe from comment #3)
> > Package Review
> > ==============
> 
> > Legend:
> > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> > [ ] = Manual review needed
> 
> 
> > Issues:
> > =======
> > - Package installs properly.
> >   Note: Installation errors (see attachment)
> >   See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
> 
> Can't install:
> 
> Error: 
>  Problem 1: conflicting requests
>   - nothing provides (crate(readwrite/default) >= 0.1.1 with
> crate(readwrite/default) < 0.2.0) needed by
> rust-pipe+bidirectional-devel-0.2.0-1.fc33.noarch
>  Problem 2: conflicting requests
>   - nothing provides (crate(readwrite/default) >= 0.1.1 with
> crate(readwrite/default) < 0.2.0) needed by
> rust-pipe+readwrite-devel-0.2.0-1.fc33.noarch
> 

Now opened: https://bugzilla.redhat.com/show_bug.cgi?id=1831106
With `rust-readwrite` installed, these two features requiring `readwrite` now
install successfully.

> > - If (and only if) the source package includes the text of the license(s)
> >   in its own file, then that file, containing the text of the license(s)
> >   for the package is included in %license.
> >   Note: License file COPYING is not marked as %license
> >   See: https://docs.fedoraproject.org/en-US/packaging-
> >   guidelines/LicensingGuidelines/#_license_text
> 
> Let's add a `%license` pointing at the  COPYING file.
> 

+1 - `%license COPYING` is now added to the specfile.

> > Rpmlint
> > -------
> > Checking: rust-pipe-devel-0.2.0-1.fc33.noarch.rpm
> > 	  rust-pipe+default-devel-0.2.0-1.fc33.noarch.rpm
> > 	  rust-pipe+bidirectional-devel-0.2.0-1.fc33.noarch.rpm
> > 	  rust-pipe+readwrite-devel-0.2.0-1.fc33.noarch.rpm
> > 	  rust-pipe+unstable-doc-cfg-devel-0.2.0-1.fc33.noarch.rpm
> > 	  rust-pipe-0.2.0-1.fc33.src.rpm
> > rust-pipe-devel.noarch: W: invalid-url URL: https://crates.io/crates/pipe HTTP Error 404: Not Found
> > rust-pipe-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/pipe-0.2.0/.cargo-checksum.json
> > rust-pipe+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/pipe HTTP Error 404: Not Found
> > rust-pipe+default-devel.noarch: W: no-documentation
> > rust-pipe+bidirectional-devel.noarch: W: invalid-url URL: https://crates.io/crates/pipe HTTP Error 404: Not Found
> > rust-pipe+bidirectional-devel.noarch: W: no-documentation
> > rust-pipe+readwrite-devel.noarch: W: spelling-error %description -l en_US readwrite -> read write, read-write, rewrite
> > rust-pipe+readwrite-devel.noarch: W: invalid-url URL: https://crates.io/crates/pipe HTTP Error 404: Not Found
> > rust-pipe+readwrite-devel.noarch: W: no-documentation
> > rust-pipe+unstable-doc-cfg-devel.noarch: W: invalid-url URL: https://crates.io/crates/pipe HTTP Error 404: Not Found
> > rust-pipe+unstable-doc-cfg-devel.noarch: W: no-documentation
> > rust-pipe.src: W: invalid-url URL: https://crates.io/crates/pipe HTTP Error 404: Not Found
> > 6 packages and 0 specfiles checked; 0 errors, 12 warnings.
> 
> I'm not sure why it's saying https://crates.io/crates/pipe is an invalid URL
> because it's working for me.
> I would ingnore the no-documentation warning.
> I wonder if we can do something about the hidden-file-or-dir warning.

The hidden-file-or-dir warning seems to come up when using the default macros -
I think this could be addressed in
https://src.fedoraproject.org/rpms/rust-srpm-macros (maybe to avoid packaging
the file altogether as it seems to
apply only to vendored rust deps, or exclude it from the hidden-file-or-dir
check). Will take a look into this.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux