https://bugzilla.redhat.com/show_bug.cgi?id=1828205 --- Comment #14 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- > I needed to do this to name the package doctest-devel. I see that in #6 you suggest renaming it doctest. Please see comments #1--#3 where this is discussed. Your recommendation appears to contradict the advice given me by David Cantrell. He gave you the wrong recommendation. The upstream name is doctest, so you must use it as the name of package. The main package will not produce any output, all logic will be moved to -devel subpackage. Read this: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/ https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries > I believe that without this line, I got an error during "make install". I'll test with your change and see, but this was only added due to a need for it. Just take my SPEC file. It builds absolutely fine and follow all Fedora guidelines. > It was my understanding that Ninja is faster for *rebuilds*, not initial builds. I'll go ahead and run with both and see if the timings are different. Make is a legacy, ancient tool. Ninja is much more better. It has no issues with special characters and generate beautiful output. > I'm using an arched package. Good. This line was for the reviewer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
