https://bugzilla.redhat.com/show_bug.cgi?id=1819180 --- Comment #13 from Ralf Senderek <fedora@xxxxxxxxxxx> --- (In reply to Petr Menšík from comment #10) > Package Review > ============== ... > --- > > Few notes: > I do not like what is done in %post script. Please move key generation to > systemd oneshot unit. It should not generate something in post script. It > should not definitely generate it as root and chown there. > Also, it seems /usr is used for configuration. Please create > %{_sysconfdir}/ssh-chat and put key there. It does not belong to /usr. If > just key is required and nothing else, %{_sysconfdir}/ssh-chat.key would be > enough. Check unbound-keygen.service from unbound package as an example. I have created a oneshot systemd unit "ssh-chat-keygen.service" that creates the RSA key for the user sshchat in %{_sysconfdir}/ssh-chat. So all configuration will be done here and not under /usr. This leads to a cleaner spec file as %post %postun and %preun can now be removed completely. > #BuildRequires: golang(github.com/alexcesaro/log) > #BuildRequires: golang(github.com/alexcesaro/log/golog) > #BuildRequires: golang(github.com/shazow/rateio) > it would be better if they got their own review and depend on it as normal > package. If they are reusable, please make them that way. At least they > should have devel subpackage with correct provides in this package. I have to disagree with you on this point, because this package does provide one single binary and no devel files nor any bundled libraries. The files SOURCE5 and SOURCE6 are neccessary only to build the binary. They are additional source code, which is not available in another package. Once someone else provides these packages as devel packages I will drop SOURCE5 and SOURCE6 in favour of these devel packages. But I will not provide anything more than the one binary, because I don't want other packages to become dependent on this one. As the source code is not signed by upstream I don't use gpgverify. SRPM and SPEC files are updated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
