https://bugzilla.redhat.com/show_bug.cgi?id=1828813 Artem <ego.cordatus@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #8 from Artem <ego.cordatus@xxxxxxxxx> --- > Yes, I thought to include these lines. But just to learn, since they are "core" packages, i.e. they are provided with a default Fedora workstation installation, and they cannot be removed without removing critical or protected packages (ie. systemd, sudo, etc.) isn't "redundant" to put a Requires directive? rpmlint says that packages requires only '/usr/bin/bash' so probably safe to add there this packages explicitly. Also zram for example package: https://src.fedoraproject.org/rpms/zram/blob/master/f/zram.spec#_18 Also, please, replace awk with gawk as i mentioned there https://bugzilla.redhat.com/show_bug.cgi?id=1828813#c5 --- %{_datadir}/%{name} -> %{_datadir}/%{name}/ Here is why this recommended to do: https://bugzilla.redhat.com/show_bug.cgi?id=1694366#c14 --- This is cosmetic, but usually maintainers doing like this: %doc README.md %doc CHANGELOG.md -> %doc README.md CHANGELOG.md --- Please fix this minor issues before import. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
