[Bug 1822971] Review Request: notcurses - character graphics and TUI library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1822971



--- Comment #38 from David Cantrell <dcantrell@xxxxxxxxxx> ---
Everything looks good.  My only suggestion is to put a blank line between
%changelog entries in the spec file, so it would look like:


%changelog
* Sat Apr 25 2020 Nick Black <dankamongmen@xxxxxxxxx> - 1.3.3-1
- New upstream version, incorporate review feedback
- Build against OpenImageIO, install notcurses-view and data.

* Tue Apr 07 2020 Nick Black <dankamongmen@xxxxxxxxx> - 1.3.3-1
- Initial Fedora packaging


But that's only for readability in the spec file.  RPM breaks all that out and
stores it in the header differently so when you do "rpm -q --changelog" it's
generating that output and not just dumping a text file.

APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux